From 131270cb2fd4354b2e996a29d4eefbaa52eb29b4 Mon Sep 17 00:00:00 2001 From: Daniel Nicoletti Date: Tue, 3 Sep 2024 10:08:27 -0300 Subject: [PATCH] Remove undefined CellReference::fromString FIXES: #327 --- QXlsx/header/xlsxcellreference.h | 7 +------ QXlsx/source/xlsxworksheet.cpp | 6 ++++++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/QXlsx/header/xlsxcellreference.h b/QXlsx/header/xlsxcellreference.h index ffef9859..6ee80ad4 100644 --- a/QXlsx/header/xlsxcellreference.h +++ b/QXlsx/header/xlsxcellreference.h @@ -7,10 +7,6 @@ QT_BEGIN_NAMESPACE_XLSX -const int XLSX_ROW_MAX = 1048576; -const int XLSX_COLUMN_MAX = 16384; -const int XLSX_STRING_MAX = 32767; - class QXLSX_EXPORT CellReference { public: @@ -29,7 +25,6 @@ class QXLSX_EXPORT CellReference ~CellReference(); QString toString(bool row_abs = false, bool col_abs = false) const; - static CellReference fromString(const QString &cell); bool isValid() const; inline void setRow(int row) { _row = row; } inline void setColumn(int col) { _column = col; } @@ -47,7 +42,7 @@ class QXLSX_EXPORT CellReference inline bool operator>(const CellReference &other) const { - return _row > other._row || _column != other._column; + return _row > other._row || _column != other._column; } private: diff --git a/QXlsx/source/xlsxworksheet.cpp b/QXlsx/source/xlsxworksheet.cpp index cebeb18b..ca3e8197 100644 --- a/QXlsx/source/xlsxworksheet.cpp +++ b/QXlsx/source/xlsxworksheet.cpp @@ -42,6 +42,12 @@ QT_BEGIN_NAMESPACE_XLSX +namespace { +const int XLSX_ROW_MAX = 1048576; +const int XLSX_COLUMN_MAX = 16384; +const int XLSX_STRING_MAX = 32767; +} // namespace + WorksheetPrivate::WorksheetPrivate(Worksheet *p, Worksheet::CreateFlag flag) : AbstractSheetPrivate(p, flag) , windowProtection(false)