Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated calculation of native direction in RZX decomposition and in UnitarySynthesis #7086

Open
eggerdj opened this issue Sep 30, 2021 · 1 comment
Open

Duplicated calculation of native direction in RZX decomposition and in UnitarySynthesis #7086

eggerdj opened this issue Sep 30, 2021 · 1 comment
Labels
type: enhancement It's working, but needs polishing

Comments

@eggerdj
Copy link
Contributor

eggerdj commented Sep 30, 2021 •
edited by ecpeterson
Loading

What is the expected enhancement?

The logic around trivial_layout https://github.com/Qiskit/qiskit-terra/blob/9cb9b6cc20eca47093e7e77f44982485bc26de1e/qiskit/transpiler/passes/optimization/echo_rzx_weyl_decomposition.py#L101 is a (simplified) duplicate of what's already in UnitarySynthesis: https://github.com/Qiskit/qiskit-terra/blob/deebd5cce63601f5a6bb4aa762baedd9cb4876b3/qiskit/transpiler/passes/synthesis/unitary_synthesis.py#L178
it would be good to merge them.

As commented here #6784 (comment) by @ecpeterson
@eggerdj eggerdj added the type: enhancement It's working, but needs polishing label Sep 30, 2021
@eggerdj eggerdj mentioned this issue Sep 30, 2021
Merged
@ecpeterson ecpeterson changed the title Trivial layout and unitary synthesis Duplicated calculation of native direction in RZX decomposition and in UnitarySynthesis Sep 30, 2021
@ecpeterson
Copy link
Contributor

(Edited the pointer to where in the code I meant.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecpeterson @eggerdj