Clean up workflow files #4357
Merged
Clean up workflow files #4357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
force-pushed
the
FH/workflow-cleanup
branch
from
3ba71cf to
9059432
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
Most notably closes #2883 by replacing all uses of `@tj-actions/changed-file` with `gh pr diff` (we decided we didn't need to investigate if we replaced the action). Also makes a couple of other tweaks: * Moves some environment variables to be defined in YML: I think this makes the workflow easier to read because the comments get syntax highlighting, and it's clearer which variables to edit. * Fix some of the regexes (😬) * Simplifies the extended notebook test: We rarely use this, so when we do I think it's acceptable to run on all files rather than those chaned between `main`.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
arnaucasau
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably closes #2883 by replacing all uses of
@tj-actions/changed-filewithgh pr diff(we decided we didn't need to investigate if we replaced the action).Also makes a couple of other tweaks:
main.