Skip to content

Commit b3df62b

Browse files
Revert "Use more modern version of changed-files action (#2814)" (#2881)
The new action is broken for `separator`, which is blocking #2757. We will find a minimum reproduction & file an issue with their repository. ## Security analysis We had landed #2757 out of an abundance-of-caution to address https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised#stepsecurity-harden-runner. The security team wanted us to be using the latest version of the action. However, it was not actually necessary to land #2757 because the prior commit we pinned to was not compromised. There is no known CVE with the old pinned commit. While it's generally a good idea to use the latest version of deps, it is not strictly necessary and in this case it is blocking us from merging to main.
1 parent 651dbe9 commit b3df62b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151

5252
- name: Get all changed docs files
5353
id: all-changed-files
54-
uses: tj-actions/changed-files@2f7c5bfce28377bc069a65ba478de0a74aa0ca32
54+
uses: tj-actions/changed-files@af2816c65436325c50621100d67f6e853cd1b0f1
5555
with:
5656
files: docs/**/*.{md,mdx,ipynb}
5757
separator: "\n"

.github/workflows/notebook-test-extended.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222

2323
- name: Get relevant changed files
2424
id: all-changed
25-
uses: tj-actions/changed-files@2f7c5bfce28377bc069a65ba478de0a74aa0ca32
25+
uses: tj-actions/changed-files@af2816c65436325c50621100d67f6e853cd1b0f1
2626
with:
2727
files: "{docs/**/*.ipynb,scripts/nb-tester/**/*}"
2828
separator: "\n"

.github/workflows/notebook-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727

2828
- name: Get relevant changed files
2929
id: all-changed
30-
uses: tj-actions/changed-files@2f7c5bfce28377bc069a65ba478de0a74aa0ca32
30+
uses: tj-actions/changed-files@af2816c65436325c50621100d67f6e853cd1b0f1
3131
with:
3232
files: "{docs/**/*.ipynb,scripts/nb-tester/**/*}"
3333
separator: "\n"

0 commit comments

Comments
 (0)