Some model rendering modules or plug-ins may use the entity's creature name to select and replace the NPC model. The previous writing method will cause the player-type NPC to always use a random numeric ID as the entity name. Therefore, in order to solve this problem, I allow NPCs to have custom names.

Author: AsukaRyo12

plugin/src/main/java/lol/pyr/znpcsplus/packets/V1_17PacketFactory.java

@@ -34,6 +34,8 @@ public void spawnEntity(Player player, PacketEntity entity, PropertyHolder prope
         sendPacket(player, new WrapperPlayServerSpawnEntity(entity.getEntityId(), Optional.of(entity.getUuid()), entity.getType(),
                 npcLocationToVector(location), location.getPitch(), location.getYaw(), location.getYaw(), 0, Optional.of(new Vector3d())));
 
+        // 设置除玩家以外的实体昵称 若display_name属性为空，则用默认实体名称
+        // Sets the nickname of an entity other than the player. If the display_name attribute is empty, the default entity name is used.
         String displayName = entity.getProperty(propertyRegistry.getByName("display_name", String.class));
         if (displayName != null) {
             EntityData<Optional<Component>> nameData = new EntityData<>(
@@ -46,17 +48,7 @@ public void spawnEntity(Player player, PacketEntity entity, PropertyHolder prope
                     Collections.singletonList(nameData)
             ));
         }
-
         sendAllMetadata(player, entity, properties);
-        EntityData<Boolean> hideNameDisplay = new EntityData<>(
-                3,
-                EntityDataTypes.BOOLEAN,
-                false
-        );
-        sendPacket(player, new WrapperPlayServerEntityMetadata(
-                entity.getEntityId(),
-                Collections.singletonList(hideNameDisplay)
-        ));
         if (EntityTypes.isTypeInstanceOf(entity.getType(), EntityTypes.LIVINGENTITY)) sendAllAttributes(player, entity, properties);
         createTeam(player, entity, properties.getProperty(propertyRegistry.getByName("glow", NamedColor.class)));
     }

plugin/src/main/java/lol/pyr/znpcsplus/packets/V1_19_3PacketFactory.java

@@ -30,8 +30,9 @@ public CompletableFuture<Void> addTabPlayer(Player player, PacketEntity entity,
 
         CompletableFuture<Void> future = new CompletableFuture<>();
 
+        // 设置玩家类型NPC的昵称 若display_name属性为空，则用默认虚拟实体ID作为名称
+        // Set the nickname of the player type NPC. If the display_name attribute is empty, the default virtual entity ID is used as the name.
         String displayName = entity.getProperty(propertyRegistry.getByName("display_name", String.class)) == null ? entity.getEntityId()+"" : entity.getProperty(propertyRegistry.getByName("display_name", String.class));
-
         skinned(player, properties, new UserProfile(entity.getUuid(), displayName)).thenAccept(profile -> {
             WrapperPlayServerPlayerInfoUpdate.PlayerInfo info = new WrapperPlayServerPlayerInfoUpdate.PlayerInfo(
                     profile, false, 1, GameMode.CREATIVE,

plugin/src/main/java/lol/pyr/znpcsplus/packets/V1_8PacketFactory.java

@@ -124,8 +124,14 @@ public void createTeam(Player player, PacketEntity entity, NamedColor namedColor
                 namedColor == null ? NamedTextColor.WHITE : NamedTextColor.NAMES.value(namedColor.name().toLowerCase()),
                 WrapperPlayServerTeams.OptionData.NONE
         )));
+
+        String displayName = entity.getProperty(propertyRegistry.getByName("display_name", String.class)) == null ? entity.getEntityId()+"" : entity.getProperty(propertyRegistry.getByName("display_name", String.class));
+        // 这个displayName替换掉原来的变量，是为了
+        // '当NPC实体为玩家类型时，隐藏掉NPC头顶上的名称显示 不然会和hologram一起显示 导致有些混淆与冲突'
+        // This displayName replaces the original variable in order to
+        // 'hide the name display above the NPC's head when the NPC entity is a player type, otherwise it will be displayed together with the hologram, causing some confusion and conflict'
         sendPacket(player, new WrapperPlayServerTeams("npc_team_" + entity.getEntityId(), WrapperPlayServerTeams.TeamMode.ADD_ENTITIES, (WrapperPlayServerTeams.ScoreBoardTeamInfo) null,
-                entity.getType() == EntityTypes.PLAYER ? Integer.toString(entity.getEntityId()) : entity.getUuid().toString()));
+                entity.getType() == EntityTypes.PLAYER ? displayName : entity.getUuid().toString()));
     }
 
     @Override