From 05f418c1f14b0e3155000d0db02f893a055c9c50 Mon Sep 17 00:00:00 2001 From: serializedowen Date: Thu, 4 Feb 2021 17:14:34 +0800 Subject: [PATCH] fix: changed event listener attach point moved "mouseup" listener to document root, otherwise if you mouse away from element without triggering mouseup, the ripple container will persist in place. --- src/ripple.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ripple.js b/src/ripple.js index 55179c0..07d2b38 100644 --- a/src/ripple.js +++ b/src/ripple.js @@ -104,7 +104,7 @@ var Ripple = { rippleContainer.parentNode.removeChild(rippleContainer); }, 850); - el.removeEventListener('mouseup', clearRipple, false); + document.removeEventListener('mouseup', clearRipple, false); // After removing event set position to target to it's original one // Timeout it's needed to avoid jerky effect of ripple jumping out parent target @@ -129,7 +129,7 @@ var Ripple = { } if(event.type === 'mousedown') { - el.addEventListener('mouseup', clearRipple, false); + document.addEventListener('mouseup', clearRipple, false); } else { clearRipple(); } @@ -146,4 +146,4 @@ function setProps(modifiers,props) { }); } -export default Ripple; \ No newline at end of file +export default Ripple;