Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyObjectInit should be private (and sealed) #4552

Closed
davidhewitt opened this issue Sep 13, 2024 · 4 comments · Fixed by #4611
Closed

PyObjectInit should be private (and sealed) #4552

davidhewitt opened this issue Sep 13, 2024 · 4 comments · Fixed by #4611
Labels
Good First Issue

Comments

@davidhewitt
Copy link
Member

davidhewitt commented Sep 13, 2024 •
edited
Loading

PyObjectInit trait is an implementation detail. We should remove it from the public API. If it's needed in macros, we'll move it inside src/impl_/.

#4518 (comment)
@cesarmg1980
Copy link

Hey @davidhewitt can I give it a look ?

@davidhewitt
Copy link
Member Author

Please go for it; as far as I know nobody is working on this.

@Cheukting
Copy link
Contributor

If this is not done yet, I am happy to follow up

@Cheukting Cheukting mentioned this issue Oct 10, 2024
Merged
@cesarmg1980
Copy link

cesarmg1980 commented Oct 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving PyObjectInit into impl_ and sealing the trait Cheukting/pyo3
3 participants
@davidhewitt @Cheukting @cesarmg1980