Fix test_entry_point_create_error (fix #185) (#186)

* Fix `test_entry_point_create_error` in `test_opener`

* Use supported `setuptools` for Py3.3 in Travis-CI

Author: Martin Larralde

.travis.yml

@@ -1,17 +1,21 @@
+sudo: false
 language: python
 
-python:
-  - "2.7"
-  - "3.3"
-  - "3.4"
-  - "3.5"
-  - "3.6"
-
-os:
-  - linux
+matrix:
+  include:
+  - python: "2.7"
+    env: SETUPTOOLS=setuptools
+  - python: "3.3"
+    env: SETUPTOOLS=setuptools~=39.2
+  - python: "3.4"
+    env: SETUPTOOLS=setuptools
+  - python: "3.5"
+    env: SETUPTOOLS=setuptools
+  - python: "3.6"
+    env: SETUPTOOLS=setuptools
 
 before_install:
-  - pip install setuptools pip -U
+  - pip install $SETUPTOOLS pip -U
   - pip --version
   - pip install -r testrequirements.txt
   - pip freeze

tests/test_opener.py

@@ -216,17 +216,19 @@ def test_entry_point_type_error(self):
 
     def test_entry_point_create_error(self):
 
+        class BadOpener(opener.Opener):
+            def __init__(self, *args, **kwargs):
+                raise ValueError("some creation error")
+            def open_fs(self, *args, **kwargs):
+                pass
+        
         entry_point = mock.MagicMock()
-        entry_point.load = mock.MagicMock(return_value=entry_point)
-        entry_point.side_effect = ValueError("some creation error")
-
+        entry_point.load = mock.MagicMock(return_value=BadOpener)
         iter_entry_points = mock.MagicMock(return_value=iter([entry_point]))
-        builtins = 'builtins' if six.PY3 else '__builtin__'
 
         with mock.patch('pkg_resources.iter_entry_points', iter_entry_points):
-            with mock.patch(builtins+'.issubclass', return_value=True):
-                with self.assertRaises(errors.EntryPointError) as ctx:
-                    opener.open_fs('test://')
+            with self.assertRaises(errors.EntryPointError) as ctx:
+                opener.open_fs('test://')
             self.assertEqual(
                 'could not instantiate opener; some creation error', str(ctx.exception))