Added support for user/passwd in ftp_url(). (#297)

* Modified tests for ftp_url() and geturl() methods.

Now they should support user/passwd in URL.

* Added test class for anonymous ftp-user testing.

ftp_url() and geturl() methods need special handling for anonymous input.

* Changed hard-coded 127.0.0.1 to self.server.host

Should now pass CI...

* Added support for user/passwd in ftp_url()

* Changed assertTrue() to assertEqual()

assertEqual provides more information than assertTrue.

* Added port to test_ftp_url(), replaced assertTrue to assertEqual.

* Update CHANGELOG.md

* Update CONTRIBUTORS.md

Author: zmej-serow

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.4.8] - 2019-06-11
+
+### Changed
+
+- `geturl` will return URL with user/password if needed @zmej-serow
+
 ## [2.4.7] - 2019-06-08
 
 ### Added
@@ -15,7 +21,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
-- Implemented geturl in FTPFS @zmej-serow
+- Implemented `geturl` in FTPFS @zmej-serow
 
 ### Fixed
 

CONTRIBUTORS.md

@@ -6,3 +6,4 @@ Many thanks to the following developers for contributing to this project:
 - [Giampaolo](https://github.com/gpcimino)
 - [Martin Larralde](https://github.com/althonos)
 - [Will McGugan](https://github.com/willmcgugan)
+- [Zmej Serow](https://github.com/zmej-serow)

fs/ftpfs.py

@@ -440,11 +440,9 @@ def _manage_ftp(self):
     def ftp_url(self):
         # type: () -> Text
         """Get the FTP url this filesystem will open."""
-        url = (
-            "ftp://{}".format(self.host)
-            if self.port == 21
-            else "ftp://{}:{}".format(self.host, self.port)
-        )
+        _host_part = self.host if self.port == 21 else "{}:{}".format(self.host, self.port)
+        _user_part = "" if self.user == "anonymous" or self.user is None else "{}:{}@".format(self.user, self.passwd)
+        url = "ftp://{}{}".format(_user_part, _host_part)
         return url
 
     @property

tests/test_ftpfs.py

@@ -166,15 +166,21 @@ def tearDown(self):
         super(TestFTPFS, self).tearDown()
 
     def test_ftp_url(self):
-        self.assertTrue(self.fs.ftp_url.startswith("ftp://127.0.0.1"))
+        self.assertEqual(self.fs.ftp_url, "ftp://{}:{}@{}:{}".format(self.user, self.pasw, self.server.host, self.server.port))
 
     def test_geturl(self):
         self.fs.makedir("foo")
         self.fs.create("bar")
         self.fs.create("foo/bar")
-        self.assertTrue(self.fs.geturl('foo') == "ftp://127.0.0.1:{}/foo".format(self.server.port))
-        self.assertTrue(self.fs.geturl('bar') == "ftp://127.0.0.1:{}/bar".format(self.server.port))
-        self.assertTrue(self.fs.geturl('foo/bar') == "ftp://127.0.0.1:{}/foo/bar".format(self.server.port))
+        self.assertEqual(
+            self.fs.geturl('foo'), "ftp://{}:{}@{}:{}/foo".format(self.user, self.pasw, self.server.host, self.server.port)
+        )
+        self.assertEqual(
+            self.fs.geturl('bar'), "ftp://{}:{}@{}:{}/bar".format(self.user, self.pasw, self.server.host, self.server.port)
+        )
+        self.assertEqual(
+            self.fs.geturl('foo/bar'), "ftp://{}:{}@{}:{}/foo/bar".format(self.user, self.pasw, self.server.host, self.server.port)
+        )
 
     def test_host(self):
         self.assertEqual(self.fs.host, self.server.host)
@@ -244,3 +250,62 @@ def make_fs(self):
 
     def test_features(self):
         pass
+
+    
+@attr("slow")
+class TestAnonFTPFS(FSTestCases, unittest.TestCase):
+
+    user = "anonymous"
+    pasw = ""
+
+    @classmethod
+    def setUpClass(cls):
+        from pyftpdlib.test import ThreadedTestFTPd
+
+        super(TestAnonFTPFS, cls).setUpClass()
+
+        cls._temp_dir = tempfile.mkdtemp("ftpfs2tests")
+        cls._temp_path = os.path.join(cls._temp_dir, text_type(uuid.uuid4()))
+        os.mkdir(cls._temp_path)
+
+        cls.server = ThreadedTestFTPd()
+        cls.server.shutdown_after = -1
+        cls.server.handler.authorizer = DummyAuthorizer()
+        cls.server.handler.authorizer.add_anonymous(cls._temp_path, perm="elradfmw")
+        cls.server.start()
+
+        # Don't know why this is necessary on Windows
+        if platform.system() == "Windows":
+            time.sleep(0.1)
+        # Poll until a connection can be made
+        if not cls.server.is_alive():
+            raise RuntimeError("could not start FTP server.")
+
+    @classmethod
+    def tearDownClass(cls):
+        cls.server.stop()
+        shutil.rmtree(cls._temp_dir)
+        super(TestAnonFTPFS, cls).tearDownClass()
+
+    def make_fs(self):
+        return open_fs(
+            "ftp://{}:{}".format(
+                self.server.host, self.server.port
+            )
+        )
+
+    def tearDown(self):
+        shutil.rmtree(self._temp_path)
+        os.mkdir(self._temp_path)
+        super(TestAnonFTPFS, self).tearDown()
+
+    def test_ftp_url(self):
+        self.assertEqual(self.fs.ftp_url, "ftp://{}:{}".format(self.server.host, self.server.port))
+
+    def test_geturl(self):
+        self.fs.makedir("foo")
+        self.fs.create("bar")
+        self.fs.create("foo/bar")
+        self.assertEqual(self.fs.geturl('foo'), "ftp://{}:{}/foo".format(self.server.host, self.server.port))
+        self.assertEqual(self.fs.geturl('bar'), "ftp://{}:{}/bar".format(self.server.host, self.server.port))
+        self.assertEqual(self.fs.geturl('foo/bar'), "ftp://{}:{}/foo/bar".format(self.server.host, self.server.port))