Skip to content

Commit f4dd130

Browse files
Rok OblakMargeBot
Rok Oblak
authored and
MargeBot
committed
Fix tests
MAILANDR-2511: search no results issue
1 parent ee15336 commit f4dd130

File tree

3 files changed

+26
-11
lines changed

3 files changed

+26
-11
lines changed

mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/local/SearchResultsLocalDataSourceImplTest.kt

+14-2
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,24 @@ class SearchResultsLocalDataSourceImplTest {
7272
fun `delete search results calls corresponding dao function with given parameters`() = runTest {
7373
// Given
7474
val keyword = "keyword"
75-
coEvery { searchResultDao.deleteAll(userId, keyword) } just runs
75+
coEvery { searchResultDao.deleteAllForKeyword(userId, keyword) } just runs
7676

7777
// When
7878
searchResultsLocalDataSource.deleteResults(userId, keyword)
7979

8080
// Then
81-
coVerify(exactly = 1) { searchResultDao.deleteAll(userId, keyword) }
81+
coVerify(exactly = 1) { searchResultDao.deleteAllForKeyword(userId, keyword) }
82+
}
83+
84+
@Test
85+
fun `delete all search results calls corresponding dao function with given parameters`() = runTest {
86+
// Given
87+
coEvery { searchResultDao.deleteAll(userId) } just runs
88+
89+
// When
90+
searchResultsLocalDataSource.deleteAllResults(userId)
91+
92+
// Then
93+
coVerify(exactly = 1) { searchResultDao.deleteAll(userId) }
8294
}
8395
}

mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/repository/SearchResultsRepositoryImplTest.kt

+9-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
package ch.protonmail.android.mailmessage.data.repository
2020

21+
import ch.protonmail.android.mailmessage.data.local.MessageLocalDataSource
2122
import ch.protonmail.android.mailmessage.data.local.SearchResultsLocalDataSource
2223
import io.mockk.coEvery
2324
import io.mockk.coVerify
@@ -31,21 +32,24 @@ import kotlin.test.Test
3132
class SearchResultsRepositoryImplTest {
3233

3334
private val userId = UserId("1")
34-
private val keyword = "keyword"
3535
private val searchResultsLocalDataSource = mockk<SearchResultsLocalDataSource>()
36+
private val messageLocalDataSource = mockk<MessageLocalDataSource>()
3637
private val searchResultsRepository = SearchResultsRepositoryImpl(
37-
localDataSource = searchResultsLocalDataSource
38+
localDataSource = searchResultsLocalDataSource,
39+
messageLocalDataSource = messageLocalDataSource
3840
)
3941

4042
@Test
4143
fun `delete all should call delete search results from local data source`() = runTest {
4244
// Given
43-
coEvery { searchResultsLocalDataSource.deleteResults(userId, keyword) } just runs
45+
coEvery { searchResultsLocalDataSource.deleteAllResults(userId) } just runs
46+
coEvery { messageLocalDataSource.deleteSearchIntervals(userId) } just runs
4447

4548
// When
46-
searchResultsRepository.deleteAll(userId, keyword)
49+
searchResultsRepository.deleteAll(userId)
4750

4851
// Then
49-
coVerify(exactly = 1) { searchResultsLocalDataSource.deleteResults(userId, keyword) }
52+
coVerify(exactly = 1) { searchResultsLocalDataSource.deleteAllResults(userId) }
53+
coVerify(exactly = 1) { messageLocalDataSource.deleteSearchIntervals(userId) }
5054
}
5155
}

mail-message/domain/src/test/kotlin/ch/protonmail/android/mailmessage/domain/usecase/DeleteSearchResultsTest.kt

+3-4
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,12 @@ class DeleteSearchResultsTest {
3737
@Test
3838
fun `delete search results calls repository with given parameters`() = runTest {
3939
// Given
40-
val keyword = "keyword"
41-
coEvery { searchResultsRepository.deleteAll(userId, keyword) } just runs
40+
coEvery { searchResultsRepository.deleteAll(userId) } just runs
4241

4342
// When
44-
deleteMessages(userId, keyword)
43+
deleteMessages(userId)
4544

4645
// Then
47-
coVerify { searchResultsRepository.deleteAll(userId, keyword) }
46+
coVerify { searchResultsRepository.deleteAll(userId) }
4847
}
4948
}

0 commit comments

Comments
 (0)