refactor: rename rollouts_per_example to group_size#2597
Closed
mikasenghaas wants to merge 1 commit into
Closed
Conversation
Renames the orchestrator-level, [orchestrator.eval] group-level, and per-env [[orchestrator.eval.env]] fields. The old name still parses as a validation alias in both TOML and CLI, so existing configs keep working unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollouts_per_example→group_sizeonOrchestratorConfig,EvalConfig, andEvalEnvConfig.rollouts_per_exampleas a Pydanticvalidation_aliasso existing configs and CLI invocations keep working unchanged (no deprecation warning — silent alias).configs/andexamples/to the new name, plus the orchestrator/scheduler/envs call sites and docs (docs/slurm.md,docs/bring-your-own-algorithms.md).Verification
Verified by hand (no new unit tests):
rollouts_per_exampleunder[orchestrator],[orchestrator.eval], and[[orchestrator.eval.env]]resolves togroup_sizeon the parsed config.--orchestrator.rollouts-per-example 4resolves toconfig.orchestrator.group_size == 4.configs/andexamples/against the config classes — no new failures vs. main.