-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployments: investigate support for build
and push
settings
#342
Comments
@mitchnielsen - thanks for getting this ticket together, and for your work to date on the prefect provider. So far it has been smooth sailing to work with. We are evaluating prefect and scoping out how we want to do our deployments. Basically all of our other systems deploy through terraform (technically speaking it is CDKTF) so there would be some benefit for us to have everything that way (including flow deploys which are currently using the yaml deploy in our proof of concept). After looking at the deployment stuff a bit more, I certainly see a way forward without having the build and push settings being supported. I would also sort of buy the argument that it might not make sense for the prefect provider / deployment resource to have those responsibilities. For our use case (AWS ECS repo for the image), it should all be doable by pulling in the AWS provider and the Docker provider. Something like resource "aws_ecr_repository" "repo" {
name = "repo"
image_tag_mutability = "MUTABLE"
image_scanning_configuration {
scan_on_push = true
}
}
resource "docker_image" "my_flow" {
name = "000000000000.dkr.ecr.us-west-2.amazonaws.com/repo/my-flow"
build {
context = "."
tag = ["my-flow:latest"]
}
} When you define the flow, you can reference the |
Cheers, thanks, that's great to hear 🤝
That's good context to have, thanks - when we kick this off I'd like to set up a functional example using config similar to that and make sure it works. If we don't directly add |
build
and push
settingsbuild
and push
settings
Adds documentation addressing the build and push actions from the Prefect CLI and what alternatives exist for the Terraform provider. Closes https://linear.app/prefect/issue/PLA-861/deployments-investigate-support-for-build-and-push-settings Closes #342
Adds documentation addressing the build and push actions from the Prefect CLI and what alternatives exist for the Terraform provider. Closes https://linear.app/prefect/issue/PLA-861/deployments-investigate-support-for-build-and-push-settings Closes #342
Summary
Let's investigate supporting the
build
andpush
settings in the Deployment resource in our provider.Acceptance criteria
build
settings can work and make sense in the provider, create an issue for supporting thempush
settings can work and make sense in the provider, create an issue for supporting themThe text was updated successfully, but these errors were encountered: