Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Pool creation/edit not respecting required fields #1568

Closed
jakekaplan opened this issue Jul 11, 2023 · 5 comments
Closed

Work Pool creation/edit not respecting required fields #1568

jakekaplan opened this issue Jul 11, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@jakekaplan
Copy link
Contributor

When creating a WorkPool, there can be a number of form fields that can required. The UI used to validate these fields before letting you proceed to creating a work pool.

Repro:

  1. Create an AzureContainerInstance WorkPool
  2. Fill in no options for the base job template (note that resource_group_name and subscription_id and required in the response from /views/aggregate-worker-metadata)
  3. Observe the work pool is created successfully

Screenshot 2023-07-11 at 12 00 41 PM
Screenshot 2023-07-11 at 12 01 36 PM
Screenshot 2023-07-11 at 12 01 55 PM

@jakekaplan jakekaplan added the bug Something isn't working label Jul 11, 2023
@znicholasbrown
Copy link
Contributor

Ah - this was an expected regression from #1560 but will be un-regressed (re-regressed? fixed.) with the release of this code. Given that the fix is already merged, I'm going to close this.

@WillRaphaelson
Copy link
Contributor

Thanks @znicholasbrown - if theres not a planned release of this by noon tomorrow could we get one out the door?

@znicholasbrown
Copy link
Contributor

Yup 👍🏻

@znicholasbrown
Copy link
Contributor

Just kidding, while what I said was true as well, the work pool creation wizard didn't have a validation observer on the infra creation step -this PR adds one and will close this issue properly.

Resolved by: #1570

@znicholasbrown
Copy link
Contributor

#1570 is merged and will go out with the next release (today or tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants