Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split modules to separate repos to improve modularity #27

Open
achubaty opened this issue Apr 22, 2022 · 1 comment
Open

split modules to separate repos to improve modularity #27

achubaty opened this issue Apr 22, 2022 · 1 comment
Assignees

Comments

@achubaty
Copy link
Collaborator

  1. easier to not use certain modules (like we did for AB NRV, where we provided our our regime pars);
  2. finer-grain control over module updates (currently unable to pull updates for specific modules; all-or-none), which reduces merge conflicts introduced when scfm being used in multiple projects.

@SteveCumming I understand that we had previously discussed this and agreed to hold off because you were actively developing and encountered issues using git submodules, but now that scfm is primarily being maintained by Ian (with support from me), this will vastly simplify scfm integration across multiple projects. Additionally, Eliot's recent creation of SpaDES.install::getModule() allows users to get modules without needing to use git.

@ianmseddy this is high on my TODO list and I'd like to discuss further, as it will have implications for existing/ongoing projects using scfm.

@achubaty achubaty self-assigned this Apr 22, 2022
@achubaty
Copy link
Collaborator Author

this is still on my radar, to be completed after new package sfcmutils used throughout modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant