Skip to content

Terminology sweep: end users see only 'session' + event-type names (~30 strings + maxSlots rename) #1011

Description

@teetangh

Context

The audit's terminology sweep found the slot/session/call/meeting/appointment vocabulary leaking across layers. Buyers see "N calls per week" while shopping (app/explore/experts/[consultantId]/components/ExpertPricing.tsx:168) and "sessions" while attending; one sentence mixes meeting and session (EventTimingsCalendar.tsx:159); "slot" leaks to consultees at checkout (app/checkout/plans/consultation/[planId]/page.tsx:294, 508); validator errors use session, calls, and classes for the same concept. Roughly 30 strings carry most of the visibility. Internally, SlotLimits.maxSlots actually holds a SESSION count for subscriptions — a naming trap flagged during #998 review.

Proposed approach

Adopt the two-level canon from the audit: developers keep the schema vocabulary (slot = 30-minute atom, appointment = DB wrapper, plan, request, meeting = live call); end users only ever see "session", "time", the event-type names, "booking", and "spot" for waitlists. Ship a mechanical PR that rewrites the ~30 high-visibility strings (the allocationMessages.ts catalog centralizes many already) and renames SlotLimits.maxSlots to a session-count name. The callsPerWeek/meetingsPerWeeksessionsPerWeek schema unification is a separate decision that must be made before the schema freeze.

Audit area 3; found alongside #998.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions