Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Output buffer size/shape check #722

Open
Jerry-Jinfeng-Guo opened this issue Sep 16, 2024 · 0 comments
Open

[FEATURE] Output buffer size/shape check #722

Jerry-Jinfeng-Guo opened this issue Sep 16, 2024 · 0 comments
Labels
feature New feature or request

Comments

@Jerry-Jinfeng-Guo
Copy link
Contributor

Issue

When adding a buffer to output dataset during batch calculations, users can misuse/abuse the fact that there is no additional check between the user indicated output shape and the actual output shape. For example, in a pf calculation for 10 nodes with batch size 4, the user can add a buffer of 1x10, instead of 4x10. In return, only the first 10 nodes (from the first batch) will be filled to the buffer.

Possible solution

In the main core, functionalities should be put in place to verify whether both shapes match. In case of a smaller buffer being provided, warnings should be given clearly stating that the output result is in-complete. In the case of the opposite, message should be communicated accordingly that provided buffer is more than necessary.

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label Sep 16, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title [FEATURE] Output buffer size check [FEATURE] Output buffer size/shape check Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant