Clean up and refactor

Author: maxachis

src/external/pdap/_templates/request_builder.py

@@ -38,10 +38,27 @@ async def post(
             raise Exception(f"Failed to make request to PDAP: {response_info.data}")
         return response_info.data
 
+    async def post_v2(
+        self,
+        url: str,
+        request_model: BaseModel,
+        return_model_type: type[T]
+    ) -> T:
+        request_info = RequestInfo(
+            type_=RequestType.POST,
+            url=url,
+            json_=request_model.model_dump(mode='json'),
+            headers=await self.access_manager.jwt_header()
+        )
+        response_info: ResponseInfo = await self.access_manager.make_request(request_info)
+        if response_info.status_code != HTTPStatus.OK:
+            raise Exception(f"Failed to make request to PDAP: {response_info.data}")
+        return return_model_type(**response_info.data)
+
     async def get(
         self,
         url: str,
-        model: type[T]
+        return_model_type: type[T]
     ) -> T:
         request_info = RequestInfo(
             type_=RequestType.GET,
@@ -51,7 +68,7 @@ async def get(
         response_info: ResponseInfo = await self.access_manager.make_request(request_info)
         if response_info.status_code != HTTPStatus.OK:
             raise Exception(f"Failed to make request to PDAP: {response_info.data}")
-        return model(**response_info.data)
+        return return_model_type(**response_info.data)
 
     @abstractmethod
     async def inner_logic(self) -> Any:

src/external/pdap/client.py

@@ -22,26 +22,3 @@ async def run_request_builder(
         request_builder: PDAPRequestBuilderBase
     ) -> Any:
         return await request_builder.run(self.access_manager)
-
-    async def is_url_duplicate(
-        self,
-        url_to_check: str
-    ) -> bool:
-        """
-        Check if a URL is unique. Returns duplicate info otherwise
-        """
-        url: str = f"{self.access_manager.data_sources_url}/v2/check/unique-url"
-
-        request_info = RequestInfo(
-            type_=RequestType.GET,
-            url=url,
-            params={
-                "url": url_to_check
-            }
-        )
-        response_info: ResponseInfo = await self.access_manager.make_request(request_info)
-        duplicates: list[UniqueURLDuplicateInfo] = [
-            UniqueURLDuplicateInfo(**entry) for entry in response_info.data["duplicates"]
-        ]
-        is_duplicate: bool = (len(duplicates) != 0)
-        return is_duplicate

src/external/pdap/impl/sync/follows/core.py

@@ -8,6 +8,6 @@ async def inner_logic(self) -> list[SyncFollowGetInnerResponse]:
         url: str = self.build_url("v3/sync/follows")
         response: SyncFollowGetOuterResponse = await self.get(
             url=url,
-            model=SyncFollowGetOuterResponse
+            return_model_type=SyncFollowGetOuterResponse
         )
         return response.follows

tests/automated/integration/api/proposals/test_agencies.py

@@ -85,6 +85,7 @@ async def test_agencies(
     agencies: list[Agency] = await adb_client.get_all(Agency)
     assert len(agencies) == 1
     agency = agencies[0]
+    assert agency.id == agency_id
     assert agency.name == request.name
     assert agency.agency_type == request.agency_type
     assert agency.jurisdiction_type == request.jurisdiction_type