fix: update views outside of setter (revert 814c4eb

)

Author: Draconizations

src/components/dash/groups/GroupControls.svelte

@@ -32,6 +32,7 @@
 
   if (dash.settings.display?.keepOpen && list.settings.view.type === ViewType.COLLAPSE) {
     list.settings.viewType = ViewType.OPEN
+    list.settings.changeView()
   }
 
   let filterGroups = $state(list.filters)
@@ -85,6 +86,9 @@
       class="input input-sm input-bordered join-item flex-1"
       id="member-list-view"
       bind:value={list.settings.viewType}
+      onchange={() => {
+        list.settings.changeView()
+      }}
     >
       <option value={dash.settings.display?.keepOpen === true ? ViewType.OPEN : ViewType.COLLAPSE}
         >List</option

src/components/dash/members/MemberControls.svelte

@@ -32,6 +32,7 @@
 
   if (dash.settings.display?.keepOpen && list.settings.view.type === ViewType.COLLAPSE) {
     list.settings.viewType = ViewType.OPEN
+    list.settings.changeView()
   }
 
   let filterGroups = $state(list.filters)
@@ -85,6 +86,9 @@
       class="input input-sm input-bordered join-item flex-1"
       id="member-list-view"
       bind:value={list.settings.viewType}
+      onchange={() => {
+        list.settings.changeView()
+      }}
     >
       <option value={dash.settings.display?.keepOpen === true ? ViewType.OPEN : ViewType.COLLAPSE}
         >List</option

src/lib/dash/dash.svelte.ts

@@ -151,6 +151,7 @@ function createMemberListState(data: any): DashList<Member> {
       sorts = data?.view.m[1]
       if (data?.view.m.length > 2) {
         listSettings.viewType = data?.view.m[2]
+        listSettings.changeView()
       }
       listSettings.filterMode = "advanced"
     }
@@ -235,6 +236,7 @@ function createGroupListState(data: any): DashList<Group> {
       sorts = data?.view.g[1]
       if (data?.view.g.length > 2) {
         listSettings.viewType = data?.view.g[2]
+        listSettings.changeView()
       }
       listSettings.filterMode = "advanced"
     }

src/lib/dash/settings.svelte.ts

@@ -15,7 +15,7 @@ interface View {
   defaultItemsPerPage: number
 }
 
-const availableViews: View[] = [
+let availableViews: View[] = [
   {
     type: ViewType.COLLAPSE,
     itemsPerPageSelection: [10, 25, 50],
@@ -51,6 +51,7 @@ const availableViews: View[] = [
 export interface ListSettings {
   readonly view: View
   viewType: ViewType
+  changeView: () => void
   itemsPerPage: number
   currentPage: number
   filterMode: "simple" | "advanced"
@@ -79,13 +80,35 @@ export function createListSettings(): ListSettings {
     },
     set viewType(type: ViewType) {
       viewType = type
+    },
+    changeView: () => {
       itemsPerPage = view.defaultItemsPerPage
       currentPage = 1
     },
-    itemsPerPage,
-    currentPage,
-    filterMode,
-    extraFields,
+    get itemsPerPage() {
+      return itemsPerPage
+    },
+    set itemsPerPage(ipp: number) {
+      itemsPerPage = ipp
+    },
+    get currentPage() {
+      return currentPage
+    },
+    set currentPage(page: number) {
+      currentPage = page
+    },
+    get filterMode() {
+      return filterMode
+    },
+    set filterMode(mode: "simple" | "advanced") {
+      filterMode = mode
+    },
+    get extraFields() {
+      return extraFields
+    },
+    set extraFields(open: boolean) {
+      extraFields = open
+    },
   }
 }