Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple choice checkbox displays on one line #108

Closed
d-horner opened this issue Nov 11, 2020 · 3 comments
Closed

Multiple choice checkbox displays on one line #108

d-horner opened this issue Nov 11, 2020 · 3 comments
Assignees
Labels

Comments

@d-horner
Copy link

Using a large list of multiple select options incorrectly displays choices on one line:
image

Adding a <br> tag within the for loop in the questions.html template resolves this display issue:
image

I am guessing it is due to wrapping and some CSS somewhere, but I've not had the chance to look into it quite yet.

d-horner added a commit to d-horner/django-survey that referenced this issue Nov 11, 2020
@Pierre-Sassoulas
Copy link
Owner

Good catch ! Could we use something like this instead ? https://getbootstrap.com/docs/4.0/components/input-group/#checkboxes-and-radios. Or maybe django boostrap form "crispy" {{ form|crispy }}. I'll let you choose the solution between those 2 or a simple <br> as we already have boostrap and django-boostrap-form as dependencies.

@d-horner
Copy link
Author

I was actually going to suggest creating a boostrap4 branch as the current repo makes use of bootstrap3 (I did a quick once over and there were only one or two CSS selectors that should/would need updating).

I would propose going a step further and creating a more accessible stylesheet than the current implementation. The grey backdrop doesn't meet the contrast ratio required for WCAG 3 accessibility guidelines - I know this is a minor suggestion, possibly due to use case (patient research)/HIPAA compliance background, but it can't hurt?

If this is something that you would be interested in pursuing I would happily contribute to this end!

@Pierre-Sassoulas
Copy link
Owner

Pierre-Sassoulas commented Nov 11, 2020

Sure thing, let's do this in another pull request than polish translation, so I can merge polish and <br> first then ;)

I created #109.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants