Merge pull request #485 from PermanentOrg/noissue-fix-stela-time-conversions

Don't reformat stela timestamps

Author: slifty

CHANGELOG.md

@@ -7,53 +7,56 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.9.1] - 2025-03-13
+
+### Fixed
+
+- Stela endpoint response dates are no longer being incorrectly modified by the SDK.
+
 ## [0.9.0] - 2025-03-12
 
-## Added
+### Added
 
 - ClientConfiguration now accepts a `stelaBaseUrl`
 
-## Changed
+### Changed
 
 - BREAKING CHANGE: Dropped support for Node 18.
 - BREAKING CHANGE: getFolder() now uses stela endpoints, which uses `stelaBaseUrl`.
 - Added optional failOnDuplicateName parameters to createFolder and createArchiveRecord
 
 ## [0.8.0] - 2024-08-28
 
-## Changed
+### Changed
 
 - BREAKING CHANGE: All functions now take either one or two arguments. The first argument is always the `ClientConfig`
   object. The second argument, if it is present, is always an object containing the rest of the parameters for the
   function. Documentation describing each function and its inputs has been added in API.md.
 
 ## [0.7.0] - 2024-02-23
 
-## Added
+### Added
 
 - The `updateShareLink` function now exists
-
-## Added
-
 - The `createShareLink` function now exists
 
-## Changed
+### Changed
 
 - This package no longer supports Node v14.
 - The `deleteFolder` and `deleteArchiveRecord` SDK methods now return void (was boolean).
 - All SDK methods now throw if the server responds with a non-OK status.
 
-## Added
+### Added
 
 - The `HttpResponseError` type now exists.
 
 ## [0.6.0] - 2023-05-18
 
-## Changed
+### Changed
 
 - The `createArchiveRecord` function no longer uploads files, clients must use the new `uploadFile` function for this.
 
-## Added
+### Added
 
 - The `uploadFile` function now exists.
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@permanentorg/sdk",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "description": "Functional Node.js SDK for Permanent.org",
   "module": "dist/esm/index.js",
   "main": "dist/cjs/index.js",

src/sdk/__tests__/__snapshots__/getFolder.test.ts.snap

@@ -19,7 +19,7 @@ describe('getFolder', () => {
     const firstChildrenPage = nock('https://api.permanent.local')
       .get('/api/v2/folder/7457/children')
       .query({
-        pageSize: 20,
+        pageSize: 100,
       })
       .replyWithFile(
         200,
@@ -32,7 +32,7 @@ describe('getFolder', () => {
     const secondChildrenPage = nock('https://api.permanent.local')
       .get('/api/v2/folder/7457/children')
       .query({
-        pageSize: 20,
+        pageSize: 100,
         cursor: '1575064',
       })
       .replyWithFile(

src/sdk/__tests__/fixtures/getFolder/stelaChildrenPageOne.json

@@ -17,7 +17,7 @@ export interface GetFolderParams {
   folderId: number;
 }
 
-const LOAD_CHILDREN_PAGE_SIZE = 20;
+const LOAD_CHILDREN_PAGE_SIZE = 100;
 
 const loadAllStelaChildrenForFolder = async (
   clientConfiguration: ClientConfiguration,

src/sdk/__tests__/getFolder.test.ts

@@ -2,7 +2,6 @@ import {
   DerivativeType,
   isDerivativeType,
 } from '../types';
-import { formatTimestampAsUtc } from './formatTimestampAsUtc';
 import type {
   File,
   StelaFile,
@@ -20,6 +19,6 @@ export const stelaFileToFile = (stelaFile: StelaFile): File => ({
   downloadUrl: stelaFile.downloadUrl,
   checksum: '',
   size: stelaFile.size,
-  createdAt: new Date(formatTimestampAsUtc(stelaFile.createdAt)),
-  updatedAt: new Date(formatTimestampAsUtc(stelaFile.updatedAt)),
+  createdAt: new Date(stelaFile.createdAt),
+  updatedAt: new Date(stelaFile.updatedAt),
 });

src/sdk/getFolder.ts

@@ -1,4 +1,3 @@
-import { formatTimestampAsUtc } from './formatTimestampAsUtc';
 import type {
   StelaFolder,
   Folder,
@@ -10,11 +9,11 @@ export const stelaFolderToFolder = (stelaFolder: StelaFolder): Folder => ({
   name: stelaFolder.displayName,
   fileSystemCompatibleName: stelaFolder.downloadName,
   size: stelaFolder.size ?? 0,
-  createdAt: new Date(formatTimestampAsUtc(stelaFolder.createdAt)),
-  updatedAt: new Date(formatTimestampAsUtc(stelaFolder.updatedAt)),
+  createdAt: new Date(stelaFolder.createdAt),
+  updatedAt: new Date(stelaFolder.updatedAt),
   displayDate: stelaFolder.displayTimestamp === null || stelaFolder.displayTimestamp === undefined
     ? null
-    : new Date(formatTimestampAsUtc(stelaFolder.displayTimestamp)),
+    : new Date(stelaFolder.displayTimestamp),
   folders: [],
   archiveRecords: [],
 });