Skip to content

Commit 9719015

Browse files
feat: adds angular 19 support (ng-select#2465)
BREAKING CHANGE: minimum required angular version is 19.0.0 --------- Co-authored-by: Pavan Kumar Jadda <[email protected]>
1 parent 6217b52 commit 9719015

File tree

64 files changed

+2604
-2020
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+2604
-2020
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Setup Node
1818
uses: actions/setup-node@v4
1919
with:
20-
node-version: 'latest'
20+
node-version: '20'
2121

2222
- name: Install dependencies
2323
run: yarn install

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Setup Node
1818
uses: actions/setup-node@v4
1919
with:
20-
node-version: 'latest'
20+
node-version: '20'
2121
cache: yarn
2222
cache-dependency-path: yarn.lock
2323

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ See [Demo](https://ng-select.github.io/ng-select) page.
1616

1717
| Angular | ng-select |
1818
|------------------|:---------:|
19+
| >=19.0.0 <20.0.0 | v14.x |
1920
| >=18.0.0 <19.0.0 | v13.x |
2021
| >=17.0.0 <18.0.0 | v12.x |
2122
| >=16.0.0 <17.0.0 | v11.x |

angular.json

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,12 @@
8080
"prefix": "",
8181
"architect": {
8282
"build": {
83-
"builder": "@angular-devkit/build-angular:browser-esbuild",
83+
"builder": "@angular-devkit/build-angular:application",
8484
"options": {
85-
"outputPath": "dist/demo",
85+
"outputPath": {
86+
"base": "dist/demo"
87+
},
8688
"index": "src/demo/index.html",
87-
"main": "src/demo/main.ts",
8889
"polyfills": [
8990
"zone.js"
9091
],
@@ -97,7 +98,8 @@
9798
"styles": [
9899
"src/demo/styles.scss"
99100
],
100-
"scripts": []
101+
"scripts": [],
102+
"browser": "src/demo/main.ts"
101103
},
102104
"configurations": {
103105
"production": {

package.json

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,33 +31,33 @@
3131
]
3232
},
3333
"dependencies": {
34-
"@angular/animations": "^18.2.5",
35-
"@angular/common": "^18.2.5",
36-
"@angular/compiler": "^18.2.5",
37-
"@angular/core": "^18.2.5",
38-
"@angular/forms": "^18.2.5",
39-
"@angular/localize": "^18.2.5",
40-
"@angular/platform-browser": "^18.2.5",
41-
"@angular/platform-browser-dynamic": "^18.2.5",
42-
"@angular/router": "^18.2.5",
43-
"@angular/ssr": "^18.2.5",
34+
"@angular/animations": "^19.0.0",
35+
"@angular/common": "^19.0.0",
36+
"@angular/compiler": "^19.0.0",
37+
"@angular/core": "^19.0.0",
38+
"@angular/forms": "^19.0.0",
39+
"@angular/localize": "^19.0.0",
40+
"@angular/platform-browser": "^19.0.0",
41+
"@angular/platform-browser-dynamic": "^19.0.0",
42+
"@angular/router": "^19.0.0",
43+
"@angular/ssr": "^19.0.0",
4444
"@ng-bootstrap/ng-bootstrap": "^17.0.0",
4545
"@popperjs/core": "^2.11.8",
4646
"bootstrap": "^5.3.3",
4747
"rxjs": "^7.8.1",
4848
"tslib": "^2.6.2",
49-
"zone.js": "~0.14.10"
49+
"zone.js": "~0.15.0"
5050
},
5151
"devDependencies": {
52-
"@angular-devkit/build-angular": "^18.2.5",
52+
"@angular-devkit/build-angular": "^19.0.0",
5353
"@angular-eslint/builder": "18.3.1",
5454
"@angular-eslint/eslint-plugin": "18.3.1",
5555
"@angular-eslint/eslint-plugin-template": "18.3.1",
5656
"@angular-eslint/schematics": "18.3.1",
5757
"@angular-eslint/template-parser": "18.3.1",
58-
"@angular/cli": "^18.2.5",
59-
"@angular/compiler-cli": "^18.2.5",
60-
"@angular/language-service": "^18.2.5",
58+
"@angular/cli": "^19.0.0",
59+
"@angular/compiler-cli": "^19.0.0",
60+
"@angular/language-service": "^19.0.0",
6161
"@semantic-release/changelog": "^6.0.3",
6262
"@stackblitz/sdk": "^1.11.0",
6363
"@types/jasmine": "~5.1.4",
@@ -79,7 +79,7 @@
7979
"karma-coverage": "^2.2.1",
8080
"karma-jasmine": "~5.1.0",
8181
"karma-jasmine-html-reporter": "^2.1.0",
82-
"ng-packagr": "^18.2.1",
82+
"ng-packagr": "^19.0.0",
8383
"node-gyp": "^10.2.0",
8484
"prettier": "^3.3.3",
8585
"sass": "^1.79.2",

src/demo/app/app.component.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ import { filter, map, mergeMap } from 'rxjs/operators';
55
import { NgSelectConfig } from '@ng-select/ng-select';
66

77
@Component({
8-
selector: 'demo-app',
9-
templateUrl: './app.component.html',
10-
styleUrls: ['./app.component.scss'],
11-
changeDetection: ChangeDetectionStrategy.Default,
8+
selector: 'demo-app',
9+
templateUrl: './app.component.html',
10+
styleUrls: ['./app.component.scss'],
11+
changeDetection: ChangeDetectionStrategy.Default,
12+
standalone: false
1213
})
1314
export class AppComponent {
1415
title: string;

src/demo/app/examples/append-to-example/append-to-example.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import { Component, OnInit } from '@angular/core';
22
import { DataService } from '../data.service';
33

44
@Component({
5-
selector: 'ng-append-to-example',
6-
templateUrl: './append-to-example.component.html',
7-
styleUrls: ['./append-to-example.component.scss'],
8-
// encapsulation: ViewEncapsulation.ShadowDom,
5+
selector: 'ng-append-to-example',
6+
templateUrl: './append-to-example.component.html',
7+
styleUrls: ['./append-to-example.component.scss'],
8+
standalone: false
99
})
1010
export class AppendToExampleComponent implements OnInit {
1111
people: any = [];

src/demo/app/examples/bindings-custom-example/bindings-custom-example.component.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import { Component, OnInit } from '@angular/core';
22

33
@Component({
4-
selector: 'ng-bindings-custom-example',
5-
templateUrl: './bindings-custom-example.component.html',
6-
styleUrls: ['./bindings-custom-example.component.scss'],
4+
selector: 'ng-bindings-custom-example',
5+
templateUrl: './bindings-custom-example.component.html',
6+
styleUrls: ['./bindings-custom-example.component.scss'],
7+
standalone: false
78
})
89
export class BindingsCustomExampleComponent implements OnInit {
910
cities = [

src/demo/app/examples/bindings-default-example/bindings-default-example.component.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import { Component, OnInit } from '@angular/core';
22

33
@Component({
4-
selector: 'ng-bindings-default-example',
5-
templateUrl: './bindings-default-example.component.html',
6-
styleUrls: ['./bindings-default-example.component.scss'],
4+
selector: 'ng-bindings-default-example',
5+
templateUrl: './bindings-default-example.component.html',
6+
styleUrls: ['./bindings-default-example.component.scss'],
7+
standalone: false
78
})
89
export class BindingsDefaultExampleComponent implements OnInit {
910
defaultBindingsList = [

src/demo/app/examples/bindings-nested-example/bindings-nested-example.component.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import { Component, OnInit } from '@angular/core';
22

33
@Component({
4-
selector: 'ng-bindings-nested-example',
5-
templateUrl: './bindings-nested-example.component.html',
6-
styleUrls: ['./bindings-nested-example.component.scss'],
4+
selector: 'ng-bindings-nested-example',
5+
templateUrl: './bindings-nested-example.component.html',
6+
styleUrls: ['./bindings-nested-example.component.scss'],
7+
standalone: false
78
})
89
export class BindingsNestedExampleComponent implements OnInit {
910
countries = [

0 commit comments

Comments
 (0)