Skip to content

Commit 71e9ada

Browse files
Merge pull request #70 from PepperStones/develop
[FIX] 구성원 추가 시, 유효성 검사 추가
2 parents 20da343 + 0c6f5f2 commit 71e9ada

3 files changed

Lines changed: 19 additions & 0 deletions

File tree

src/main/java/pepperstone/backend/common/repository/UserRepository.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,5 @@ Slice<UserEntity> findAllWithFilters(@Param("search") String search,
3131

3232
List<UserEntity> findByJobGroup_CenterGroup_CenterNameAndJobGroup_JobName(String centerGroup, String jobGroup);
3333
List<UserEntity> findByJobGroupId(Long jobGroupId);
34+
Boolean existsByUserId(String userId);
3435
}

src/main/java/pepperstone/backend/member/controller/MemberController.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,12 @@ public ResponseEntity<Map<String, Object>> updateMember(@PathVariable("userId")
127127
@PostMapping("/add")
128128
public ResponseEntity<Map<String, Object>> addMember(@RequestBody MemberAddRequestDTO dto) {
129129
try {
130+
if(memberService.duplicateUserId(dto.getUserId()))
131+
throw new IllegalArgumentException("중복된 아이디입니다.");
132+
133+
if(!memberService.checkCompanyNum(dto.getCompanyNum()))
134+
throw new IllegalArgumentException("사번이 잘못되었습니다.");
135+
130136
memberService.addMemberAndJobGroup(dto);
131137

132138
return ResponseEntity.ok().body(Map.of("code", 200, "data", true));

src/main/java/pepperstone/backend/member/service/MemberService.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,18 @@ public void addMemberAndJobGroup(MemberAddRequestDTO dto) {
131131
}
132132
}
133133

134+
public Boolean duplicateUserId(final String userId) {
135+
return userRepo.existsByUserId(userId);
136+
}
137+
138+
public Boolean checkCompanyNum(final String companyNum) {
139+
// 10자리인지 확인 && 숫자만 있는지 확인
140+
if (companyNum.length() != 10 || !companyNum.matches("\\d+"))
141+
return false;
142+
143+
return true;
144+
}
145+
134146
// ============== private method ================
135147

136148
private boolean isNotBlank(String value) {

0 commit comments

Comments
 (0)