Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split_non_commuting's expected PyTreeDef does not match observed PyTreeDef #1099

Open
erick-xanadu opened this issue Sep 5, 2024 · 0 comments

Comments

@erick-xanadu
Copy link
Contributor

  • Expected behavior:

In pytest/test_transform.py, when changing @sum_expand in TestSumExpand to @qml.transforms.split_non_commuting as suggested by the warning, I expect the tree def to remain the same.

  • Actual behavior: A tuple is returned instead of a list.
diff --git a/frontend/test/pytest/test_transform.py b/frontend/test/pytest/test_transform.py
index 9fcb8457..a616bdb6 100644
--- a/frontend/test/pytest/test_transform.py
+++ b/frontend/test/pytest/test_transform.py
@@ -41,7 +41,7 @@ try:
 except:  # pylint: disable=bare-except
     from pennylane.transforms import qcut
 
-from pennylane.transforms import merge_rotations, sum_expand
+from pennylane.transforms import merge_rotations
 
 from catalyst import measure, qjit
 from catalyst.utils.exceptions import CompileError
@@ -375,7 +375,7 @@ class TestSumExpand:
         def qnode_builder(device_name):
             """Builder"""
 
-            @sum_expand
+            @qml.transforms.split_non_commuting
             @qml.qnode(qml.device(device_name, wires=2, shots=None))
             def qfunc():
                 """Example taken from PL tests"""
erick-xanadu added a commit that referenced this issue Sep 10, 2024
**Context:** `sum_expand` is deprecated and will be removed in the next
release of PL.

**Description of the Change:** Change calls to `sum_expand` to
`split_non_commuting`.

**Benefits:** No warnings, same functionality.

**Possible Drawbacks:** For some reason the pytree is not working
correctly. This happens for several other transforms as well.

**Related GitHub Issues:** #1099 

Since this does not update the project, just the tests, a changelog is
not needed.
mehrdad2m pushed a commit that referenced this issue Sep 17, 2024
**Context:** `sum_expand` is deprecated and will be removed in the next
release of PL.

**Description of the Change:** Change calls to `sum_expand` to
`split_non_commuting`.

**Benefits:** No warnings, same functionality.

**Possible Drawbacks:** For some reason the pytree is not working
correctly. This happens for several other transforms as well.

**Related GitHub Issues:** #1099 

Since this does not update the project, just the tests, a changelog is
not needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant