Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server URL should be robust to trailing slashes #9

Open
ashiklom opened this issue Nov 5, 2020 · 1 comment
Open

Server URL should be robust to trailing slashes #9

ashiklom opened this issue Nov 5, 2020 · 1 comment

Comments

@ashiklom
Copy link
Member

ashiklom commented Nov 5, 2020

This should work, whether or not there is a trailing slash:

IP <- "http://localhost:8000/"
server <- connect(IP, username = "carya", password = "illinois")
ping(server)
# Sorry! Server not responding.

However, it currently only works if there is not a trailing slash (i.e., http://localhost:8000).
@DMRathod
Copy link
Contributor

@robkooper i have created PR for this issue. let me know if any further changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashiklom @DMRathod