Updated VignetteBuilder field to include knitr and rmarkdown #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotroph
reviewed
Oct 29, 2024
infotroph
approved these changes
Nov 3, 2024
|
The remaining CI failures are an unrelated known issue (Docker deployment only works right from same-fork branches atm) and do not need to delay merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the DESCRIPTION file to include both knitr and rmarkdown in the VignetteBuilder field. This change ensures that all necessary dependencies for building vignettes are explicitly declared.
Motivation and Context
This change addresses issue #3392 to prevent errors when building vignettes that depend on rmarkdown.