Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic handling of PublicationXref #1441

Open
jvwong opened this issue Dec 7, 2023 · 1 comment
Open

More generic handling of PublicationXref #1441

jvwong opened this issue Dec 7, 2023 · 1 comment

Comments

@jvwong
Copy link
Member

jvwong commented Dec 7, 2023

It is not safe to assume that a PublicationXref originates from PubMed, as we have done. Article references from elsewhere would break the existing logic:

let publicationList = publications.map( publication => {
let { id, title, firstAuthor, date, source } = publication;
return h('div.cy-overflow-content', [
h('a.plain-link', { href: 'http://identifiers.org/pubmed/' + id, target: '_blank' }, title),
h('div', firstAuthor + ' et al. | ' + source + ' - ' + new Date(date).getFullYear().toString())
]);
});

In this case, it also makes sense to utilize available information about an article, so that the system need not make additional calls or support an external web service to retrieve it (e.g. crossref).

Related to: PathwayCommons/factoid#1218

@jvwong
Copy link
Member Author

jvwong commented Dec 11, 2023

At this point, references to an article are through PubMed and is baked into EXTENDED_BINARY_SIF. So there will need to be some design changes to the source x-SIF data....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant