Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Inevitable Critical Support #298

Open
3 tasks done
jjbi123 opened this issue Jan 18, 2025 · 3 comments
Open
3 tasks done

Add support for Inevitable Critical Support #298

jjbi123 opened this issue Jan 18, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@jjbi123
Copy link

jjbi123 commented Jan 18, 2025

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

  • [Inevitable Critical Gem] In game when I use Falling Thunder and I haven't crit in 4 seconds it boosts my crit chance by 100%. Skill breakdown in-game shows 40.48%.
  • [Longshot Gem] In game when I use Falling Thunder and my enemy is further than 7 meters it increases my attack damage by 35%

What is the value from the calculation in Path of Building?

  • [Inevitable Critical Gem] In PoB there doesn't to appear to be such a calculation, my projectile crit chance for FT says 31.68% even though I don't have "Have crit recently" checked in config.
  • [Longshot Gem] Even though I've set my config to 7 for "Melee distance to enemy" (I'm assuming meters is the unit) the damage doesn't change at all. (Also set projectile travel distance to 7 in case that's what it's looking at).

How to reproduce the issue

  1. Select Falling Thunder projectile as main skill.

  2. Toggle "Have you Crit Recently"? on and off and see how Crit Chance doesn't change

  3. Select Falling Thunder projectile as main skill.

  4. Toggle "Melee distance to enemy"/"Projectile travel distance" on and off and see how skill attack damage doesn't change.

Character build code

https://maxroll.gg/poe2/pob/75qb0y0l

Screenshots

Configuration

Image

Crit Calc

Image

@jjbi123 jjbi123 changed the title Invoker Monk Falling Thunder not calculating gem support right Invoker Monk Falling Thunder not calculating gem support right (crit and damge) Jan 18, 2025
@jjbi123 jjbi123 changed the title Invoker Monk Falling Thunder not calculating gem support right (crit and damge) Invoker Monk Falling Thunder not calculating gem support right (crit and dage) Jan 18, 2025
@jjbi123 jjbi123 changed the title Invoker Monk Falling Thunder not calculating gem support right (crit and dage) Invoker Monk Falling Thunder not calculating gem support right (crit and damage) Jan 18, 2025
@LocalIdentity
Copy link
Contributor

The distance value is based on 10 units = 1m so you need to set the distance to 70. Inevitable Critical doesn't work as the gem text is red

Image
If the text is red, the mod is not supported in PoB yet

I can't change the title of this issue but can you please make it "Add support for Inevitable Critical Support"

@jjbi123 jjbi123 changed the title Invoker Monk Falling Thunder not calculating gem support right (crit and damage) Add support for Inevitable Critical Support Jan 18, 2025
@jjbi123
Copy link
Author

jjbi123 commented Jan 18, 2025

@LocalIdentity Ahh!

Thank you for responding and apologies, didn't catch that red means not supported. Appreciate you guys.
Should we keep it open or close the issue?

@LocalIdentity
Copy link
Contributor

Keeping it open is fine as the gem does need support still

@deathbeam deathbeam added the enhancement New feature or request label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants