Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global_theme as environment variable via docker-compose.yaml #839

Open
mkne opened this issue Jan 24, 2025 · 2 comments
Open

global_theme as environment variable via docker-compose.yaml #839

mkne opened this issue Jan 24, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@mkne
Copy link
Contributor

mkne commented Jan 24, 2025

Is your feature request related to a problem? Please describe.
I would love to set a default theme (for example "united") for new users other than the default bootstrap theme ("") via global_theme.
However it looks like there is no GLOBAL_THEME variable defined in the parameter.yaml/docker-compose.yaml?

Describe the solution you'd like
Enable setting a GLOBAL_THEME variable in docker-compose.yaml to one of the values from partdb.available_themes

Describe alternatives you've considered
Changing the default theme via the config/parameters.yaml file is not very useful when using docker compose, as it might/will be lost when updating the container. Also the documentation says: "You should expect, that you will have to do some manual merge, when you have changed something here and update to a newer version of Part-DB."

I haven't found any discussion or issue regarding this topic. I would also consider this very low priority. But it seems easy to implement.

@mkne mkne added the enhancement New feature or request label Jan 24, 2025
@jbtronics
Copy link
Member

I am working on a new settings system, where you can configure things like this via the Web interface (you can still override them via env if you want that). The default theme will be one of the options.

So that should be configurable more easily in Part-DB 2.0.

@mkne
Copy link
Contributor Author

mkne commented Jan 31, 2025

So, should I close this issue as it is already planned? @jbtronics The feature you've mentioned is already work in progress in the branch https://github.com/Part-DB/Part-DB-server/tree/settings-bundle, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants