Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 02 editor review #1

Open
16 of 18 tasks
fredhohman opened this issue Oct 2, 2020 · 8 comments
Open
16 of 18 tasks

Issue 02 editor review #1

fredhohman opened this issue Oct 2, 2020 · 8 comments
Assignees

Comments

@fredhohman
Copy link
Member

fredhohman commented Oct 2, 2020

  • Header spacing and alignment for names on left-aligned articles
  • Add left and right padding on body text (maybe whole article container?) on mobile view for centered articles (carbon history, sinking delta)
  • Gray background on another article?
  • Footer hover link is light gray on read next article block, low contrast
  • Footer mobile view social icons are stacked, needs alignment with the links
  • Develop join parametric email list component
  • Paste email list component once in every article
  • Paste more from parametric component in every article
  • TOC only show underline on hover, currently always displayed. If this is desired, then we should have at least one hover style state
  • Add editor names on bottom of article like issue 01?
  • Standardize reference format
  • Centered title text is clipped on tablet screen size - more generally, make sure title is responsive (drop font size a little?)
  • pull number size is slightly too big (but let's keep bigger), or target numbers in margin differently
  • mobile styles for ParametricGraphic: stack all three pieces vertically? (see streaming for solution we could incorporate)
  • dropdown select tag is too wide on mobile and causing horizontal scrolling (problem found from carbon history)

Adding sara's notes:

  • Caption/Graphic line height
  • List font
  • next article hover state
@sarastalla
Copy link

Screen Shot 2020-10-02 at 2 53 41 PM

check line height on all captions/simulations

@sarastalla
Copy link

Screen Shot 2020-10-02 at 3 13 48 PM

typeface standardization
(are we changing the typeface for bulleted lists?)

@sarastalla
Copy link

Screen Shot 2020-10-02 at 3 28 13 PM

link hover color is blue 🤔

@fredhohman
Copy link
Member Author

Screen Shot 2020-10-02 at 3 13 48 PM

typeface standardization
(are we changing the typeface for bulleted lists?)

agreed this looks a little funny

@fredhohman
Copy link
Member Author

Screen Shot 2020-10-02 at 3 28 13 PM

link hover color is blue 🤔

this is likely an out of date component on the article, think redeploying the preview will fix it!

@mathisonian
Copy link
Member

Gray background on another article?

I asked Christina what she thought about switching to dark mode to match the others, will see what she says.

Add editor names on bottom of article like issue 01?

Maybe its covered by the "Editors Note"? But I'm also okay to add, don't have really strong feelings on this one

@mathisonian
Copy link
Member

mathisonian commented Oct 13, 2020

The newsletter component should be ready to drop in. For the left aligned articles I would recommend using

[Desktop]
  [Aside]
    [Newsletter /]
  [/Aside]
[/Desktop]

...

[Mobile]
    [Newsletter /]
[/Mobile]

at the relevant places and share the same centered component across desktop and mobile for the centered articles.

@mathisonian
Copy link
Member

Okay, [Recirc /] should be ready as well. Try

[Desktop]
  [Aside]
    [Recirc slug:parametricSlug /]
  [/Aside]
[/Desktop]

on left aligned and just

    [Recirc slug:parametricSlug /]

on centered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants