Add webpack 5 import instructions to readme #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to address the following: PaperStrike#239
PaperStrike
requested changes
Nov 22, 2021
| @@ -65,6 +65,12 @@ Import the default value from `pjax.esm.js` or `pjax.esm.min.js` as: | |||
| import Pjax from './dist/pjax.esm.js'; | |||
| ``` | |||
|
|
|||
| ##### To import as ES module with Webpack 5 bundler | |||
There was a problem hiding this comment.
This applies to not only webpack 5, but any tool that can parse the exports field well, so it's better if you widen that description. And import it this way is actually preferred, so the description could be like:
# Pick a script in `dist` folder ## Automatic Pick [[description]] <script src="@sliphua/pjax"></script> or import Pjax from '@sliphua/pjax'; ## To declare globally … ## To import as ES module …
PaperStrike
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to address the following:
#239