Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages vitest and @vitest/coverage-v8 #2461

Open
palisadoes opened this issue Aug 13, 2024 · 16 comments
Open

Upgrade packages vitest and @vitest/coverage-v8 #2461

palisadoes opened this issue Aug 13, 2024 · 16 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation good first issue Good for newcomers parent Parent issue security Security fix test Testing application

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade vitest and @vitest/coverage-v8. These dependencies needed to be updated together.
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps vitest and @vitest/coverage-v8. These dependencies needed to be updated together.
Updates vitest from 1.6.0 to 2.0.3

Release notes

Sourced from vitest's releases.

v2.0.3

   🚀 Features

   🐞 Bug Fixes

    View changes on GitHub

v2.0.2

   🐞 Bug Fixes

   🏎 Performance

    View changes on GitHub

v2.0.1

   🐞 Bug Fixes

    View changes on GitHub

v2.0.0

... (truncated)

Commits
  • 81b8d67 chore: release v2.0.3
  • 09dc75c chore(deps): update dependency @​edge-runtime/vm to v4 (#6047)
  • f851982 fix: --inspect-brk stop on Windows (#6110)
  • 99a12ae chore: release v2.0.2
  • 80a43d5 fix(browser): inline pretty-format and replace picocolors with tinyrainbow (#...
  • 7012f8c docs: add env documentation (#6063)
  • 16eb6c8 chore: release v2.0.1
  • 4b03e72 fix(browser): correctly inherit browser config in a workspace (#6054)
  • 4d5597d fix(vitest): print only running files, not every file (#6052)
  • 1b150a3 chore: release v2.0.0
  • Additional commits viewable in compare view

Updates @vitest/coverage-v8 from 1.6.0 to 2.0.3

Release notes

Sourced from @​vitest/coverage-v8's releases.

v2.0.3

   🚀 Features

   🐞 Bug Fixes

    View changes on GitHub

v2.0.2

   🐞 Bug Fixes

   🏎 Performance

    View changes on GitHub

v2.0.1

   🐞 Bug Fixes

    View changes on GitHub

v2.0.0

... (truncated)

Commits
  • 81b8d67 chore: release v2.0.3
  • 99a12ae chore: release v2.0.2
  • 80a43d5 fix(browser): inline pretty-format and replace picocolors with tinyrainbow (#...
  • 16eb6c8 chore: release v2.0.1
  • 1b150a3 chore: release v2.0.0
  • 5611895 chore: release v2.0.0-beta.13
  • 368c137 fix(coverage): remove work-around for implicit else (#6014)
  • 05d5f38 chore(deps): update all non-major dependencies (#5957)
  • 169bc1f fix(coverage): support overriding exclude (#5997)
  • cd9cc6b chore: release v2.0.0-beta.12
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers security Security fix dependencies Pull requests that update a dependency file labels Aug 13, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Aug 13, 2024
@akash0708
Copy link

Hello @palisadoes . I have been looking forward to contribute to Talawa for a long time, would have loved to work on this issue but, I cannot find the packages being used in the repo. Neither of them are present in the list of dependencies or devDependencies in package.json. Can anyone please help me out a bit?

@varshith257
Copy link
Member

@akash0708 What dependencies you are looking at? If new packages needed in upgradation of vitest , go ahead with them

@akash0708
Copy link

akash0708 commented Aug 15, 2024

@varshith257 as of now there is no existence of vitest anywhere in package.json , so what should I update? Should I install it?

@varshith257
Copy link
Member

@akash0708 Sorry for the confusion! This is an issue in the talawa-api. I will move there. Would you like to work on this?

@varshith257 varshith257 transferred this issue from PalisadoesFoundation/talawa-admin Aug 15, 2024
@varshith257 varshith257 removed the unapproved Unapproved for Pull Request label Aug 15, 2024
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Aug 15, 2024
@varshith257 varshith257 removed the unapproved Unapproved for Pull Request label Aug 15, 2024
@akash0708
Copy link

@varshith257 yes I would like to work on this issue.

@akash0708
Copy link

Hello I've upgraded vitest and @vitest/coverage-v8 to the required versions, but am encountering this error when I try to commit. Any idea regarding how I should go about debugging it?

image

I have not changed any of these files. I have just updated the required dependencies.

@palisadoes
Copy link
Contributor Author

Please ask the #talawa-api slack channel. Make sure you are making edits to a local branch based on the most current develop branch.

@akash0708
Copy link

Yes I am working on the latest develop branch. I have asked my query in the slack channel.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 28, 2024
@palisadoes
Copy link
Contributor Author

unassigning. inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 31, 2024
@ARYANSHAH1567
Copy link

Can you assign the issue to me?

@palisadoes
Copy link
Contributor Author

@ARYANSHAH1567

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@akshayw1
Copy link

akshayw1 commented Sep 9, 2024

Can I get the issue assigned @Cioppolo14

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Sep 20, 2024
@Cioppolo14
Copy link
Contributor

@akshayw1 Are you working on this?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Sep 21, 2024
@akshayw1
Copy link

akshayw1 commented Sep 21, 2024

Yes, need 3 days more, Will raise a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation good first issue Good for newcomers parent Parent issue security Security fix test Testing application
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

6 participants