Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User membershipRequest showing unexpected behavior #2242

Open
Azad99-9 opened this issue Apr 21, 2024 · 24 comments
Open

User membershipRequest showing unexpected behavior #2242

Azad99-9 opened this issue Apr 21, 2024 · 24 comments
Assignees
Labels
bug Something isn't working feature request no-issue-activity No issue activity

Comments

@Azad99-9
Copy link

Azad99-9 commented Apr 21, 2024

Describe the bug
before testing set org's userRegistrationRequired: true.

Three cases of unexpected behaviour related to membershipRequests

case 1. Everytime register with a fresh account, new membershipRequest is being added to org's membershipRequests field but not to user's membershipRequests field.

case 2. Even if the requests are being added to the org's membershipRequests field but they are not fetchable in the org's query.

case 3. As soon as we send a request through the sendMembershipRequest mutation all the previously added requests are also now fetchable.

To Reproduce
Steps to reproduce the behavior:

Case 1:

  1. Register with a fresh account
  2. check the org's membershipRequests field
  3. check the new user's membershipRequests field
    You will notice the membershipRequest is will be added to the org's membershipRequests field but the same will not be reflected in the user's membershipRequests field.
case.1.webm

Case 2:

  1. signup with multiple new accounts to a single org.
  2. Now compare org's membershipRequests list in the database and the membershipRequests list fetched by the organizations query.
    you will notice a mismatch of number of requests.
case-2_NXN6S5gn.mp4

Remember this org to reproduce case 3.

Case 3:

  1. Signup with a fresh account by choosing an org different from the org used in case 2.
  2. Now use sendMembershipRequest mutation and send a request to the org said in case 2.
  3. Now compare org's membershipRequests list in the database and the membershipRequests list fetched by the organizations query.
    you will notice the mismatch of number of requests disappears.
case-3_YGAyDBMA.mp4

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@AVtheking
Copy link

I would like to work on it .

@hg6658
Copy link

hg6658 commented Apr 22, 2024

Assign me this issue please

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Apr 22, 2024
Copy link

github-actions bot commented May 3, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 3, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label May 3, 2024
@Azad99-9
Copy link
Author

Hey @AVtheking any update on this?

@AVtheking
Copy link

Hi @Azad99-9 was busy due to my exams.. will start working on it from tomorrow.

@AVtheking
Copy link

Unassigning myself busy in some other issue.

@AVtheking AVtheking removed their assignment May 19, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 30, 2024
@Chaitanya1672
Copy link

I would like to work on this issue

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jun 25, 2024
Copy link

github-actions bot commented Jul 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 5, 2024
@Chaitanya1672
Copy link

Working on it

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jul 6, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 16, 2024
@Chaitanya1672
Copy link

I am unassigning myself from my due to being occupied with other commitments.

@Chaitanya1672 Chaitanya1672 removed their assignment Jul 20, 2024
@github-actions github-actions bot removed the no-issue-activity No issue activity label Jul 21, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 1, 2024
@syedali237
Copy link

Can I be assigned this issue?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 26, 2024
@syedali237
Copy link

Working on it might take a few days..

@syedali237
Copy link

I've fixed case 1. Would you prefer I submit a PR for this now, or should I complete the fixes for the other two cases first and then make a single PR?

@Azad99-9
Copy link
Author

please do everything in a single PR and share a video of it too.

@syedali237
Copy link

syedali237 commented Sep 18, 2024

@Azad99-9 I am not sure but this issue might be an internal error with Apollo Server (apollographql/apollo-client#8898). I'm seeing the same problem when fetching members via the organization query. It seems like a broader issue with how certain queries are handled. Also on console logging the organization, it shows all the accurate data. Could we look into this? @palisadoes

@syedali237
Copy link

@Azad99-9 @palisadoes Should I raise a PR for case 1 of this issue?

Copy link

github-actions bot commented Oct 2, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 2, 2024
@syedali237
Copy link

@varshith257 Should I go ahead and raise a PR for the fixes so far? I'm still working on the other two cases but wanted to check in.

@varshith257
Copy link
Member

If you think needed multiple prs, go ahead

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 13, 2024
@palisadoes
Copy link
Contributor

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request no-issue-activity No issue activity
Projects
None yet
Development

No branches or pull requests

8 participants