Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: src/screens/UserPortal/Volunteer/Actions from Jest to Vitest #2586

Closed
VanshikaSabharwal opened this issue Dec 1, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@VanshikaSabharwal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Ensure all tests in src/screens/UserPortal/Volunteer/Actions pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Dec 1, 2024
@palisadoes palisadoes added good first issue Good for newcomers and removed documentation Improvements or additions to documentation feature request labels Dec 3, 2024
@MayankJha014
Copy link
Contributor

Hi @VanshikaSabharwal and @palisadoes ,

The migration for src/screens/UserPortal/Volunteer/Actions from Jest to Vitest is now complete. The PR addressing this issue can be found here: #2611.

Please review the changes and let me know if any further updates are required.

Thank you! 😊

@MayankJha014
Copy link
Contributor

Hi @VanshikaSabharwal and @palisadoes,

I have updated the PR to be submitted against the develop-postgres branch.You can find the updated PR here: #2612.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 17, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Dec 17, 2024
@MayankJha014
Copy link
Contributor

Its completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Archived in project
Development

No branches or pull requests

5 participants