Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: src/screens/PageNotFound from Jest to Vitest #2568

Closed
VanshikaSabharwal opened this issue Dec 1, 2024 · 7 comments
Closed

Refactor: src/screens/PageNotFound from Jest to Vitest #2568

VanshikaSabharwal opened this issue Dec 1, 2024 · 7 comments
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@VanshikaSabharwal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Ensure all tests in src/screens/PageNotFound pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@dev-mayanktiwari
Copy link

Hey @palisadoes I have opened a PR for the same. Please help me to get it merged.

@dev-mayanktiwari
Copy link

Hey @palisadoes Can you please assign this issue to me?

@palisadoes
Copy link
Contributor

unassigning. Inactivity

@rafidoth
Copy link
Contributor

I wanna work on this. Can you please assign me this one ?

@Nirvanjha2004
Copy link

Can i work on this issue ?? @palisadoes

@pratykshg9999
Copy link

pratykshg9999 commented Dec 15, 2024

Hey @palisadoes Can you please assign this issue to me ???

@rafidoth
Copy link
Contributor

@palisadoes I've already started working on this, since according to 'first come first serve' I deserve the assignment. Please assign me this one in your free time. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Status: Done
Development

No branches or pull requests

7 participants