Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: src/screens/OrganizationFunds from Jest to Vitest #2561

Closed
VanshikaSabharwal opened this issue Dec 1, 2024 · 6 comments
Closed
Assignees
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@VanshikaSabharwal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Ensure all tests in src/screens/OrganizationFunds pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Dec 1, 2024
@palisadoes palisadoes added good first issue Good for newcomers and removed documentation Improvements or additions to documentation feature request labels Dec 3, 2024
@abbi4code
Copy link
Contributor

Can i work on this issue too ? Can you please assign this to me? @palisadoes

@dhanagopu
Copy link

@abbi4code Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@abbi4code
Copy link
Contributor

I’m sorry, I wasn’t aware of this as I’m new to open source. I’ll wait for my existing two PRs to get merged before asking for more issues. In the meantime, would it be okay if I explore and work on issues in other repositories? @dhanagopu

@Cioppolo14
Copy link
Contributor

@abbi4code The 2 issue limit is across all repositories. If your PRs are held up for issues over a long period of time, please let me know and we can try to help encourage the reviewers. Thank you for your work and enthusiasm!

@abbi4code
Copy link
Contributor

Thank you! I’ll definitely reach out, but I think reviewers are already managing a lot, so I should be a little more patient.

@prathmesh703
Copy link
Contributor

can i work on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Archived in project
Development

No branches or pull requests

7 participants