Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADMIN: Fix the eslint_disable_check.py script #2257

Closed
palisadoes opened this issue Sep 9, 2024 · 4 comments
Closed

ADMIN: Fix the eslint_disable_check.py script #2257

palisadoes opened this issue Sep 9, 2024 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers unapproved

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Sep 9, 2024

Describe the bug

  1. Our code base has suffered over the years because contributors ignored linting errors
  2. We created a eslint_disable_check.py script to detect the use of the eslint-disable string in files submitted in the PR
  3. It does not work with this line // eslint-disable-next-line @typescript-eslint/no-unused-vars

To Reproduce

Steps to reproduce the behavior:

  1. Submit a PR
  2. Make one of the files have the following line in it
    1. // eslint-disable-next-line @typescript-eslint/no-unused-vars
  3. The PR does not fail

Expected behavior

  1. Submit a PR
  2. Make one of the files have the following line in it
    1. // eslint-disable-next-line @typescript-eslint/no-unused-vars
  3. The PR must fail

The script must fail with the string eslint-disable discovered any where in any line

Actual behavior

  • See above

Screenshots

  • N/A

Additional details

The same person should be assigned to both these issues

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@ARYANSHAH1567
Copy link

ARYANSHAH1567 commented Sep 15, 2024

@palisadoes I fixed the issue in API. Can you please assign it to me as i would fix it in admin also

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@palisadoes
Copy link
Contributor Author

It's assigned to you

@github-actions github-actions bot removed the no-issue-activity No issue activity label Oct 6, 2024
@ARYANSHAH1567
Copy link

@palisadoes Can you please close the issue since the pr is merged and i can be assigned other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers unapproved
Projects
None yet
Development

No branches or pull requests

2 participants