-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/upgarde @types/jest #2176
Fix/upgarde @types/jest #2176
Conversation
…#1541) * changed event date and time picker * removed enzyme
…esFoundation#1466) * Update documentation * used custom hook for localstorage * Revert "Update documentation" This reverts commit 521d8b5. * fixing documentation conflicts * removed documentation.zip * Add pre-commit hook to check localStorage usage * added check for file in check-localstorage-usage.js script * Update OrgList.test.tsx * Update getRefreshToken.test.ts * updated script and workflow to check for flag * Update documentation --------- Co-authored-by: chandel-aman <[email protected]>
…isadoesFoundation#1566) * Modified Tests for CheckInWrapper file * Update documentation * Added tests * Revert "Update documentation" This reverts commit b79d09c. * Update documentation * Revert "Update documentation" This reverts commit 5fc5098. * Update documentation * Revert "Update documentation" This reverts commit 47fbf2c.
…on#1516) - Implemented validation for the `formState.link` field to ensure that it represents a valid URL. - Proper The validation checks have been added to prevent users from submitting arbitrary or invalid strings when creating a new advertisement. - Added tests for the modified code. - Ensured no other functionality or tests fail after the changes. Signed-off-by: Akhilender <[email protected]>
* add mutations and queries * add translations * add tests * add dropdown for toggling settings on small screens * minor corrections * minor change * minor change and refactor * Update documentation * Revert "Update documentation" This reverts commit 13a638b. * Update documentation * Revert "Update documentation" This reverts commit 4293627. * Update documentation * Revert "Update documentation" This reverts commit bddc63d.
* add mutations and queries * add translations * add tests * add dropdown for toggling settings on small screens * minor corrections * minor change * minor change and refactor * Update documentation * Revert "Update documentation" This reverts commit 13a638b. * Update documentation * Revert "Update documentation" This reverts commit 4293627. * Update documentation * Revert "Update documentation" This reverts commit bddc63d. * add wait to tests
* Upgraded prettier from 2.3.2 to 3.2.5 - Upgraded prettier to latest version and matched the version to that of talawa-api - Ensured all the tests are passing - Ensured no other functionality got affected Signed-off-by: Akhilender <[email protected]> * feat: Changed all instances in code according to latest prettier format - Upgraded eslint-plugin-prettier to latest version as it was depended on the prettier version - Made sure no other functionality got affected and all the tests are passing Signed-off-by: Akhilender <[email protected]> --------- Signed-off-by: Akhilender <[email protected]>
…#1543) * Create authorized-change.py * Update authorized-changes-detection.yml * Update authorized-changes-detection.yml * Update count_changed_files.py * Update count_changed_files.py * Update count_changed_files.py * Create sensitive_files.txt * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Update count_changed_files.py * Update count_changed_files.py * Update count_changed_files.py * Delete .github/workflows/authorized-changes-detection.yml * Delete .github/workflows/authorized-change.py * reviews changes done * fetch-depth testing * Update pull-requests.yml * Update check_files.py * Update pull-requests.yml * renamed * changes * .. * reviewed changes * optimize system exits * added node-version path * black formatting added
…adoesFoundation#2049) * Event and Organization Action item layouts need to be the same * Implemented the suggested changes by coderabbitai to the spreading of `formstate`. * Refactor column config on Event Actions page to fix lint error line numbers exceeded * Replace MUI Button component with default react-bootstrap Button * Feature matching event action item table and org action item table * Changed key to `member._id` from index * Added test cases for code coverage * Added test case for status change functionality * Added test case for preCompletionNotes and postCompletionNotes column * Added test case for postCompletionNotes when its length is less than 25 * Added test case for completion Date * Added ignore code coverage command --------- Co-authored-by: Peter Harrison <[email protected]>
filtered out events from action items and created unit test to verify only action items are being displayed
* upgrade web vitals package to 4.0.2 * upgrade web vitals package to 4.0.2
* Upgrade package mui/x-data-grid * Fixed format by npm run foramt:fix
…lisadoesFoundation#2116) * Added tooltip * fixed some css * Update src/components/UserProfileSettings/UserProfile.tsx Co-authored-by: Vamshi Maskuri <[email protected]> * Update src/components/UserProfileSettings/UserProfile.tsx Co-authored-by: Vamshi Maskuri <[email protected]> * corrected tests --------- Co-authored-by: Vamshi Maskuri <[email protected]>
* Corrected the joining date on user profile * Fixed tests * changed function name to joinedDate
…#2095) * Initial commit * Updated the UI of chat screen * feat: added support to create group chat * implemented group chats * Implemented logic to send messages in group chat * refactor chat functionality * fix format * refactor code * fix failing tests * removed unwanted code * fix: formatting issues and reverted unwanted changes * removed unwanted code
chore: upgrade @emotion/react to 11.13.0 - Upgraded @emotion/react from 11.11.4 to 11.13.0 - Fixed issues arising from the upgrade - Ensured all tests pass
…#2113) * action item & add on component * admin components done * screens done * merge conflict solved * lines reduced * some linting error fixed * completed * less than 600 lines
…undation#2140) * chore: upgrade @emotion/react to 11.13.0 chore: upgrade @emotion/react to 11.13.0 - Upgraded @emotion/react from 11.11.4 to 11.13.0 - Fixed issues arising from the upgrade - Ensured all tests pass * chore: upgrade @mui/x-date-pickers from 7.6.1 to 7.11.1 - Updated @mui/x-date-pickers to the latest version (7.11.1). - Ran tests to confirm no breaking changes. * chore: upgrade @mui/x-date-pickers from 7.6.1 to 7.11.1 - Updated @mui/x-date-pickers to the latest version (7.11.1). - Adjusted dependencies to ensure compatibility. - Ran tests to confirm no breaking changes. * chore: upgrade @mui/x-date-pickers from 7.6.1 to 7.11.1 - Updated @mui/x-date-pickers to the latest version (7.11.1). - Adjusted dependencies to ensure compatibility. - Ran tests to confirm no breaking changes.
* removed * mdx removed
…on#2163) * parent outlet restructure * base for user * temp * checkpoint * add sort to getFundRaisingCampaigns * Added user pledge screen & query * Add translations, remove logs, add icon in userSidebar * Add tests for new and modified files * update createCampaign Mutation input * Remove redundant lines
…oundation#2168) Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.25.1 to 6.26.0. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/[email protected]/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n#2169) Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 4.2.2 to 4.2.3. - [Changelog](https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md) - [Commits](GoogleChrome/web-vitals@v4.2.2...v4.2.3) --- updated-dependencies: - dependency-name: web-vitals dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sass](https://github.com/sass/dart-sass) from 1.77.4 to 1.77.8. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.77.4...1.77.8) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tion#2170) Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.2.7 to 15.2.8. - [Release notes](https://github.com/lint-staged/lint-staged/releases) - [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md) - [Commits](lint-staged/lint-staged@v15.2.7...v15.2.8) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
WalkthroughThis update introduces significant enhancements across various aspects of the Talawa Admin project, including a configuration overhaul, updated localization files for multiple languages, improved GitHub workflows, and comprehensive GraphQL functionality. The integration of new scripts, style sheets, and templates aims to streamline development processes and improve user experience in the application. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant API
participant Database
User->>UI: Interacts with UI
UI->>API: Sends request (e.g., create action item)
API->>Database: Interacts with DB (CRUD operations)
Database-->>API: Returns data
API-->>UI: Sends response
UI-->>User: Displays updated information
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 40
Outside diff range, codebase verification and nitpick comments (33)
src/Constant/constant.ts (1)
6-7
: Use default values for environment-dependent constants.Consider providing a default value for
REACT_APP_BACKEND_WEBSOCKET_URL
to ensure the application can run with minimal configuration.- process.env.REACT_APP_BACKEND_WEBSOCKET_URL || ''; + process.env.REACT_APP_BACKEND_WEBSOCKET_URL || 'ws://localhost:3000';.coderabbit.yaml (1)
8-8
: Consider disablingpoem
if not needed.If generating poems in reviews is not beneficial, consider setting this option to false to streamline the review process.
public/locales/en/errors.json (1)
1-10
: LGTM! Error messages are clear and well-structured.The localization file is well-structured with clear messages. Consider ensuring consistent punctuation, such as adding a period at the end of all messages for uniformity.
- "notFound": "Not found" + "notFound": "Not found."scripts/config-overrides/index.js (1)
23-27
: Consider the impact of verbose logging.Setting the infrastructure logging level to 'verbose' can be useful for debugging but may lead to excessive logs in production. Consider adjusting the level based on the environment.
- level: 'verbose', + level: process.env.NODE_ENV === 'production' ? 'error' : 'verbose',DOCUMENTATION.md (2)
26-26
: Capitalize "Markdown".Consider capitalizing "Markdown" as it refers to the formatting language.
- 1. Add/modify the markdown documents to the `docs/` directory of the `talawa-docs` repository + 1. Add/modify the Markdown documents to the `docs/` directory of the `talawa-docs` repositoryTools
LanguageTool
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
25-25
: Address bare URL usage.Consider using Markdown syntax for the URL to avoid the bare URL warning.
- - A local version of `docs.talawa.io` should automatically launch in your browser at http://localhost:3000/ + - A local version of `docs.talawa.io` should automatically launch in your browser at [http://localhost:3000/](http://localhost:3000/)Tools
LanguageTool
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
Markdownlint
25-25: null
Bare URL used(MD034, no-bare-urls)
src/GraphQl/Mutations/VenueMutations.ts (2)
7-7
: Correct typographical error in comment.The word "Ineteger" should be corrected to "Integer".
- * @param capacity - Ineteger representing capacity of venue. + * @param capacity - Integer representing capacity of venue.
39-39
: Correct typographical error in comment.The word "Ineteger" should be corrected to "Integer".
- * @param capacity - Ineteger representing capacity of venue. + * @param capacity - Integer representing capacity of venue..github/workflows/stale.yml (1)
31-34
: Review stale and close messages for clarity.The messages for marking and closing stale issues and PRs should be clear and informative. Ensure they align with the project's communication style and provide sufficient guidance to contributors.
ISSUE_GUIDELINES.md (3)
3-3
: Consider simplifying the sentence.The sentence can be made more concise by removing "In order to".
-:+1::tada: First off, thanks for taking the time to contribute! :tada::+1: +:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
30-30
: Consider using a more formal verb.Replace "fixed" with "resolved".
-Verify whether the issue has been fixed by trying to reproduce it using the latest master or development branch in the repository. +Verify whether the issue has been resolved by trying to reproduce it using the latest master or development branch in the repository.Tools
LanguageTool
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...(FIX_RESOLVE)
35-35
: Improve wording for clarity.Consider rephrasing for clarity.
-We welcome contributors who find new ways to make the code better. +We welcome contributors who find innovative ways to improve the code.Tools
LanguageTool
[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...(MAKE_STYLE_BETTER)
README.md (1)
55-56
: Video resources section is beneficial.The link to YouTube playlists provides valuable resources for new contributors. Consider addressing the compound adjective issue flagged by LanguageTool.
- "Getting Started - Developers" + "Getting Started - Developers"Tools
LanguageTool
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.(EN_COMPOUND_ADJECTIVE_INTERNAL)
PR_GUIDELINES.md (7)
4-5
: Consider rephrasing for conciseness.The phrase "In order to" can be replaced with "To" for conciseness.
-In order to give everyone a chance to submit a pull request and contribute to the Talawa project, we have put restrictions in place. +To give everyone a chance to submit a pull request and contribute to the Talawa project, we have put restrictions in place.Tools
LanguageTool
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...(IN_ORDER_TO_PREMIUM)
31-31
: Specify language for code blocks.Add a language identifier to the fenced code block for better syntax highlighting.
-``` +```bashTools
Markdownlint
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
39-39
: Specify language for code blocks.Add a language identifier to the fenced code block for better syntax highlighting.
-``` +```bashTools
Markdownlint
39-39: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
46-46
: Avoid split infinitives.Consider rephrasing to avoid splitting the infinitive "to test."
-...you'll need to tell us what steps you followed to manually test your changes. +...you'll need to tell us what steps you followed to test your changes manually.Tools
LanguageTool
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...(SPLIT_INFINITIVE)
56-56
: Improve sentence structure.Consider adding a comma after "Therefore" for clarity.
-Therefore we make experienced maintainers of our code base review your code. +Therefore, we make experienced maintainers of our code base review your code.Tools
LanguageTool
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
59-59
: Use formal language.Consider using "resolve" instead of "fix" for a more formal tone.
-...check if all tests are passing; if not, fix the issues and then create a pull request. +...check if all tests are passing; if not, resolve the issues and then create a pull request.Tools
LanguageTool
[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...(FIX_RESOLVE)
64-64
: Use a comma for compound sentences.Add a comma before "and" to separate independent clauses.
-...we get and it won't make us look at your issue faster. +...we get, and it won't make us look at your issue faster.Tools
LanguageTool
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...(COMMA_COMPOUND_SENTENCE)
.github/workflows/countline.py (1)
197-294
: Minor Typo: Correct "voilated" to "violated".The
main
function is well-structured and performs its tasks efficiently. However, there's a typo in the comment on line 267.- # If the line rule is voilated then the value is changed to 1 + # If the line rule is violated then the value is changed to 1CONTRIBUTING.md (2)
24-27
: Consider adding "please" for a more polite tone.Adding "please" can make the request more courteous.
- Let us know immediately if you have unacceptable experiences in this area. + Please let us know immediately if you have unacceptable experiences in this area.Tools
LanguageTool
[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...(INSERT_PLEASE)
174-179
: Capitalize "Slack" for consistency.Ensure proper nouns are capitalized for consistency.
- Visit the [Talawa GitHub repository home page] for the link to join our slack channel. + Visit the [Talawa GitHub repository home page] for the link to join our Slack channel.Tools
LanguageTool
[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...(ON_SKYPE)
INSTALLATION.md (1)
60-60
: Consider adding a hyphen to "open-source"."Open source" should be hyphenated when used as a compound adjective.
- Basic `git` knowledge is required for open source contribution so make sure you're comfortable with it. + Basic `git` knowledge is required for open-source contribution, so make sure you're comfortable with it.Tools
LanguageTool
[uncategorized] ~60-~60: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basicgit
knowledge is required for open source contribution so make sure you're comfor...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...` knowledge is required for open source contribution so make sure you're comfortable with it...(AI_HYDRA_LEO_MISSING_COMMA)
public/locales/en/translation.json (1)
10-11
: Improve password and email validation messages.The messages should be more descriptive and grammatically correct.
- "password_invalid": "Password should contain atleast one lowercase letter, one uppercase letter, one numeric value and one special character", - "email_invalid": "Email should have atleast 8 characters", + "password_invalid": "Password must contain at least one lowercase letter, one uppercase letter, one numeric digit, and one special character.", + "email_invalid": "Email must be at least 8 characters long.",public/locales/fr/translation.json (4)
5-5
: Inconsistent Translation for "User Login".The translation for "User Login" is inconsistent between
loginPage
("Utilisateur en ligne") anduserLoginPage
("Utilisateur en ligne"). Ensure consistency across sections.Also applies to: 39-39
31-31
: Duplicate Translation Keys.The keys "Password_and_Confirm_password_mismatches." and "passwordMismatches" are duplicated in both
loginPage
anduserLoginPage
. Consider consolidating these keys to avoid redundancy.Also applies to: 36-36, 40-40
44-44
: Capitalization Consistency for "évènements à venir".Ensure consistent capitalization for event titles. Consider capitalizing "évènements à venir" to match other titles.
- "eventCardTitle": "évènements à venir", + "eventCardTitle": "Évènements à venir",
49-49
: Capitalization Consistency for "Derniers messages".Ensure consistent capitalization for post titles. Consider capitalizing "Derniers messages" to match other titles.
- "latestPostsTitle": "Derniers messages", + "latestPostsTitle": "Derniers Messages",public/locales/sp/translation.json (4)
3-4
: Ensure Consistent Capitalization.The translation for "fromPalisadoes" uses lowercase for "palisados," which should be capitalized as "Palisados" to match the original context.
- "fromPalisadoes": "Una aplicación de código abierto de los voluntarios de la Fundación palisados", + "fromPalisadoes": "Una aplicación de código abierto de los voluntarios de la Fundación Palisados",
21-21
: Correct Punctuation.The translation for "forgotPassword" has a space before the question mark, which should be removed.
- "forgotPassword": "Has olvidado tu contraseña ?", + "forgotPassword": "Has olvidado tu contraseña?",
47-47
: Ensure Consistent Capitalization.The translation for "fromPalisadoes" should capitalize "Palisados" for consistency.
- "fromPalisadoes": "Una aplicación de código abierto de los voluntarios de la Fundación palisados", + "fromPalisadoes": "Una aplicación de código abierto de los voluntarios de la Fundación Palisados",
58-58
: Correct Punctuation.Remove the space before the question mark in "forgotPassword."
- "forgotPassword": "Has olvidado tu contraseña ?", + "forgotPassword": "Has olvidado tu contraseña?",
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (68)
package-lock.json
is excluded by!**/package-lock.json
public/favicon.ico
is excluded by!**/*.ico
public/favicon_palisadoes.ico
is excluded by!**/*.ico
public/images/logo512.png
is excluded by!**/*.png
public/images/svg/angleDown.svg
is excluded by!**/*.svg
public/images/svg/profiledefault.svg
is excluded by!**/*.svg
public/logo192.png
is excluded by!**/*.png
public/markdown/images/install1.png
is excluded by!**/*.png
public/markdown/images/install2.png
is excluded by!**/*.png
src/assets/css/app.css.map
is excluded by!**/*.map
src/assets/images/blank.png
is excluded by!**/*.png
src/assets/images/defaultImg.png
is excluded by!**/*.png
src/assets/images/palisadoes_logo.png
is excluded by!**/*.png
src/assets/images/talawa-logo-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-dark-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-lite-200x200.png
is excluded by!**/*.png
src/assets/svgs/actionItem.svg
is excluded by!**/*.svg
src/assets/svgs/admin.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-category-icon.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-items.svg
is excluded by!**/*.svg
src/assets/svgs/angleLeft.svg
is excluded by!**/*.svg
src/assets/svgs/angleRight.svg
is excluded by!**/*.svg
src/assets/svgs/article.svg
is excluded by!**/*.svg
src/assets/svgs/blockUser.svg
is excluded by!**/*.svg
src/assets/svgs/blockedUser.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemDate.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemEvent.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemLocation.svg
is excluded by!**/*.svg
src/assets/svgs/chat.svg
is excluded by!**/*.svg
src/assets/svgs/checkInRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/dashboard.svg
is excluded by!**/*.svg
src/assets/svgs/date.svg
is excluded by!**/*.svg
src/assets/svgs/event.svg
is excluded by!**/*.svg
src/assets/svgs/eventDashboard.svg
is excluded by!**/*.svg
src/assets/svgs/eventStats.svg
is excluded by!**/*.svg
src/assets/svgs/events.svg
is excluded by!**/*.svg
src/assets/svgs/flask.svg
is excluded by!**/*.svg
src/assets/svgs/funds.svg
is excluded by!**/*.svg
src/assets/svgs/key.svg
is excluded by!**/*.svg
src/assets/svgs/listEventRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/location.svg
is excluded by!**/*.svg
src/assets/svgs/logout.svg
is excluded by!**/*.svg
src/assets/svgs/media.svg
is excluded by!**/*.svg
src/assets/svgs/newChat.svg
is excluded by!**/*.svg
src/assets/svgs/organizations.svg
is excluded by!**/*.svg
src/assets/svgs/palisadoes.svg
is excluded by!**/*.svg
src/assets/svgs/people.svg
is excluded by!**/*.svg
src/assets/svgs/plugins.svg
is excluded by!**/*.svg
src/assets/svgs/post.svg
is excluded by!**/*.svg
src/assets/svgs/posts.svg
is excluded by!**/*.svg
src/assets/svgs/requests.svg
is excluded by!**/*.svg
src/assets/svgs/roles.svg
is excluded by!**/*.svg
src/assets/svgs/settings.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Facebook-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Github-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Instagram-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Linkedin-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Reddit-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Slack-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Twitter-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Youtube-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/tags.svg
is excluded by!**/*.svg
src/assets/svgs/talawa.svg
is excluded by!**/*.svg
src/assets/svgs/user.svg
is excluded by!**/*.svg
src/assets/svgs/userEvent.svg
is excluded by!**/*.svg
src/assets/svgs/users.svg
is excluded by!**/*.svg
src/assets/svgs/venues.svg
is excluded by!**/*.svg
src/assets/talawa-logo-lite-200x200.png
is excluded by!**/*.png
Files selected for processing (104)
- .coderabbit.yaml (1 hunks)
- .env.example (1 hunks)
- .eslintignore (1 hunks)
- .eslintrc.json (4 hunks)
- .github/ISSUE_TEMPLATE/bug-report.md (2 hunks)
- .github/ISSUE_TEMPLATE/feature-request.md (2 hunks)
- .github/dependabot.yaml (1 hunks)
- .github/pull_request_template.md (2 hunks)
- .github/workflows/README.md (1 hunks)
- .github/workflows/codeql-codescan.yml (1 hunks)
- .github/workflows/compare_translations.py (1 hunks)
- .github/workflows/countline.py (1 hunks)
- .github/workflows/eslint_disable_check.py (1 hunks)
- .github/workflows/issue.yml (1 hunks)
- .github/workflows/pull-request-target.yml (1 hunks)
- .github/workflows/pull-request.yml (1 hunks)
- .github/workflows/push.yml (1 hunks)
- .github/workflows/stale.yml (1 hunks)
- .gitignore (2 hunks)
- .husky/post-merge (1 hunks)
- .husky/pre-commit (1 hunks)
- .idea/.gitignore (1 hunks)
- .idea/inspectionProfiles/Project_Default.xml (1 hunks)
- .idea/modules.xml (1 hunks)
- .idea/talawa-admin.iml (1 hunks)
- .idea/vcs.xml (1 hunks)
- .lintstagedrc.json (1 hunks)
- .node-version (1 hunks)
- .prettierignore (1 hunks)
- .prettierrc (1 hunks)
- CODEOWNERS (1 hunks)
- CODE_OF_CONDUCT.md (1 hunks)
- CODE_STYLE.md (1 hunks)
- CONTRIBUTING.md (2 hunks)
- DOCUMENTATION.md (1 hunks)
- INSTALLATION.md (1 hunks)
- ISSUE_GUIDELINES.md (1 hunks)
- PR_GUIDELINES.md (1 hunks)
- README.md (3 hunks)
- jest-preview.config.ts (1 hunks)
- jest.config.js (1 hunks)
- package.json (2 hunks)
- public/index.html (1 hunks)
- public/locales/en/common.json (1 hunks)
- public/locales/en/errors.json (1 hunks)
- public/locales/en/translation.json (1 hunks)
- public/locales/fr/common.json (1 hunks)
- public/locales/fr/errors.json (1 hunks)
- public/locales/fr/translation.json (1 hunks)
- public/locales/hi/common.json (1 hunks)
- public/locales/hi/errors.json (1 hunks)
- public/locales/hi/translation.json (1 hunks)
- public/locales/sp/common.json (1 hunks)
- public/locales/sp/errors.json (1 hunks)
- public/locales/sp/translation.json (1 hunks)
- public/locales/zh/common.json (1 hunks)
- public/locales/zh/errors.json (1 hunks)
- public/locales/zh/translation.json (1 hunks)
- public/manifest.json (1 hunks)
- schema.graphql (1 hunks)
- scripts/mocks/@dicebear/collection.ts (1 hunks)
- scripts/mocks/@dicebear/core.ts (1 hunks)
- scripts/config-overrides/custom_build.js (1 hunks)
- scripts/config-overrides/custom_start.js (1 hunks)
- scripts/config-overrides/index.js (1 hunks)
- scripts/config-overrides/package.json (1 hunks)
- scripts/custom-test-env.js (1 hunks)
- scripts/githooks/check-localstorage-usage.js (1 hunks)
- scripts/githooks/update-toc.js (1 hunks)
- scripts/test.js (1 hunks)
- setup.ts (1 hunks)
- src/App.test.tsx (1 hunks)
- src/App.tsx (1 hunks)
- src/Constant/constant.spec.ts (1 hunks)
- src/Constant/constant.ts (1 hunks)
- src/GraphQl/Mutations/ActionItemCategoryMutations.ts (1 hunks)
- src/GraphQl/Mutations/ActionItemMutations.ts (1 hunks)
- src/GraphQl/Mutations/AgendaCategoryMutations.ts (1 hunks)
- src/GraphQl/Mutations/AgendaItemMutations.ts (1 hunks)
- src/GraphQl/Mutations/CampaignMutation.ts (1 hunks)
- src/GraphQl/Mutations/CommentMutations.ts (1 hunks)
- src/GraphQl/Mutations/EventAttendeeMutations.ts (1 hunks)
- src/GraphQl/Mutations/FundMutation.ts (1 hunks)
- src/GraphQl/Mutations/OrganizationMutations.ts (1 hunks)
- src/GraphQl/Mutations/PledgeMutation.ts (1 hunks)
- src/GraphQl/Mutations/VenueMutations.ts (1 hunks)
- src/GraphQl/Mutations/mutations.ts (1 hunks)
- src/GraphQl/Queries/ActionItemCategoryQueries.ts (1 hunks)
- src/GraphQl/Queries/ActionItemQueries.ts (1 hunks)
- src/GraphQl/Queries/AgendaCategoryQueries.ts (1 hunks)
- src/GraphQl/Queries/AgendaItemQueries.ts (1 hunks)
- src/GraphQl/Queries/OrganizationQueries.ts (1 hunks)
- src/GraphQl/Queries/PlugInQueries.ts (1 hunks)
- src/GraphQl/Queries/Queries.ts (1 hunks)
- src/GraphQl/Queries/fundQueries.ts (1 hunks)
- src/assets/css/scrollStyles.css (1 hunks)
- src/assets/scss/_general.scss (1 hunks)
- src/assets/scss/_talawa.scss (1 hunks)
- src/assets/scss/_variables.scss (1 hunks)
- src/assets/scss/app.scss (1 hunks)
- src/assets/scss/components/_accordion.scss (1 hunks)
- src/assets/scss/components/_alert.scss (1 hunks)
- src/assets/scss/components/_badge.scss (1 hunks)
- src/assets/scss/components/_breadcrumb.scss (1 hunks)
Files not processed due to max files limit (45)
- src/assets/scss/components/_buttons.scss
- src/assets/scss/components/_card.scss
- src/assets/scss/components/_carousel.scss
- src/assets/scss/components/_close.scss
- src/assets/scss/components/_dropdown.scss
- src/assets/scss/components/_list-group.scss
- src/assets/scss/components/_modal.scss
- src/assets/scss/components/_nav.scss
- src/assets/scss/components/_navbar.scss
- src/assets/scss/components/_offcanvas.scss
- src/assets/scss/components/_pagination.scss
- src/assets/scss/components/_placeholder.scss
- src/assets/scss/components/_progress.scss
- src/assets/scss/components/_spinners.scss
- src/assets/scss/content/_table.scss
- src/assets/scss/content/_typography.scss
- src/assets/scss/forms/_check-radios.scss
- src/assets/scss/forms/_floating-label.scss
- src/assets/scss/forms/_form-control.scss
- src/assets/scss/forms/_input-group.scss
- src/assets/scss/forms/_range.scss
- src/assets/scss/forms/_select.scss
- src/assets/scss/forms/_validation.scss
- src/assets/svgs/social-icons/index.tsx
- src/components/ActionItems/ActionItemsContainer.module.css
- src/components/ActionItems/ActionItemsContainer.test.tsx
- src/components/ActionItems/ActionItemsContainer.tsx
- src/components/ActionItems/ActionItemsContainerMocks.ts
- src/components/ActionItems/ActionItemsContainerProps.ts
- src/components/ActionItems/ActionItemsModal.test.tsx
- src/components/ActionItems/ActionItemsModal.tsx
- src/components/ActionItems/ActionItemsModalBody.tsx
- src/components/ActionItems/ActionItemsWrapper.module.css
- src/components/ActionItems/ActionItemsWrapper.test.tsx
- src/components/ActionItems/ActionItemsWrapper.tsx
- src/components/AddOn/AddOn.test.tsx
- src/components/AddOn/AddOn.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntry.module.css
- src/components/AddOn/core/AddOnEntry/AddOnEntry.test.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntryMocks.ts
- src/components/AddOn/core/AddOnRegister/AddOnRegister.module.css
- src/components/AddOn/core/AddOnRegister/AddOnRegister.test.tsx
- src/components/AddOn/core/AddOnRegister/AddOnRegister.tsx
- src/components/AddOn/core/AddOnStore/AddOnStore.module.css
Files skipped from review due to trivial changes (32)
- .env.example
- .eslintignore
- .github/ISSUE_TEMPLATE/bug-report.md
- .github/ISSUE_TEMPLATE/feature-request.md
- .github/dependabot.yaml
- .github/workflows/README.md
- .husky/post-merge
- .idea/.gitignore
- .idea/inspectionProfiles/Project_Default.xml
- .idea/modules.xml
- .idea/talawa-admin.iml
- .idea/vcs.xml
- .lintstagedrc.json
- .node-version
- .prettierignore
- CODEOWNERS
- jest-preview.config.ts
- public/locales/fr/errors.json
- public/locales/hi/common.json
- public/locales/hi/errors.json
- public/locales/zh/common.json
- public/locales/zh/errors.json
- scripts/mocks/@dicebear/collection.ts
- scripts/mocks/@dicebear/core.ts
- scripts/config-overrides/package.json
- src/assets/css/scrollStyles.css
- src/assets/scss/_talawa.scss
- src/assets/scss/_variables.scss
- src/assets/scss/app.scss
- src/assets/scss/components/_alert.scss
- src/assets/scss/components/_badge.scss
- src/assets/scss/components/_breadcrumb.scss
Additional context used
Learnings (3)
src/GraphQl/Mutations/FundMutation.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFunds/FundDeleteModal.tsx:1-2 Timestamp: 2024-06-30T21:44:39.912Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
src/GraphQl/Mutations/CampaignMutation.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFundCampaign/CampaignDeleteModal.tsx:4-5 Timestamp: 2024-06-30T21:17:16.481Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
src/GraphQl/Queries/fundQueries.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFunds/FundDeleteModal.tsx:1-2 Timestamp: 2024-06-30T21:44:39.912Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
Biome
scripts/test.js
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
LanguageTool
DOCUMENTATION.md
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
ISSUE_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Issue Report Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...(IN_ORDER_TO_PREMIUM)
[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...(EN_A_VS_AN)
[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...(PLEASE_COMMA)
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...reported. ### New Issues To create new issues follow these steps: 1. Your issue may ...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...(FIX_RESOLVE)
[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...(MAKE_STYLE_BETTER)
[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in#talawa
slack channel. Working on these types of exi...(ON_SKYPE)
[grammar] ~53-~53: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...ew Issues 1. Join our#talawa-github
slack channel for automatic issue and pull re...(ON_SKYPE)
[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...(ON_SKYPE)
[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...(PLEASE_COMMA)
README.md
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.(EN_COMPOUND_ADJECTIVE_INTERNAL)
PR_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...(IN_ORDER_TO_PREMIUM)
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...(SPLIT_INFINITIVE)
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...(FIX_RESOLVE)
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...(COMMA_COMPOUND_SENTENCE)
[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...(MAKE_CHANGES)
CODE_OF_CONDUCT.md
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
CODE_STYLE.md
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories ofsrc
assets
- This houses all of the static assets used in the project - `...(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project -css
- This houses all of the css files used in the project - `imag...(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project -images
- This houses all of the images used in the project -scss
-...(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project -scss
- This houses all of the scss files used in the project - `c...(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms -_talawa.scss
- Partial Sass file for Talawa -_utilities.scss
- Pa...(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_utilities.scss
- Partial Sass file for utilities -_variables.scss
-...(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_variables.scss
- Partial Sass file for variables -app.scss
- Main S...(HE_VERB_AGR)
[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screensConstant
- This houses all of the constants used in the project `GraphQl...(ALL_OF_THE)
[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the projectGraphQl
- This houses all of the GraphQL queries and mutations used in t...(ALL_OF_THE)
[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the projectscreens
- This houses all of the views/screens to be navigated through i...(ALL_OF_THE)
[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Adminstate
- This houses all of the state management code for the project ...(ALL_OF_THE)
[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...(EN_COMPOUND_ADJECTIVE_INTERNAL)
CONTRIBUTING.md
[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...(INSERT_PLEASE)
[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~62-~62: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...(THE_SUPERLATIVE)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...ushed to themain
branch: -develop
: For unstable code and bug fixing - `mai...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing -main
: Where the stable production ready code lies. This is our default branch. ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~73-~73: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...(IF_THERE_COMMA)
[typographical] ~73-~73: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...(RB_LY_COMMA)
[grammar] ~73-~73: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...(FIRST_SERVED)
[uncategorized] ~73-~73: Possible missing comma found.
Context: ...esolved in a First Come First Serve basis however there are certain exceptions to...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~75-~75: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...(ON_SKYPE)
[style] ~77-~77: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)
[grammar] ~77-~77: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...(MISSING_TO_BETWEEN_BE_AND_VB)
[grammar] ~77-~77: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...(ON_SKYPE)
[misspelling] ~77-~77: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...(EN_A_VS_AN)
[typographical] ~78-~78: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...(DURING_THAT_TIME_COMMA)
[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...(MAC_OS)
[uncategorized] ~164-~164: Possible missing comma found.
Context: ...o add all changes). 1. After adding the changes you need to commit them using `git comm...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~165-~165: The past participle is required after “must be”.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...(BE_VBP_IN)
[uncategorized] ~167-~167: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...(ON_SKYPE)
INSTALLATION.md
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~54-~54: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...(DURING_THAT_TIME_COMMA)
[uncategorized] ~60-~60: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basicgit
knowledge is required for open source contribution so make sure you're comfor...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...` knowledge is required for open source contribution so make sure you're comfortable with it...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~66-~66: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open acmd
(Window...(NOUN_VERB_CONFUSION)
[grammar] ~67-~67: The operating system from Apple is written “macOS”.
Context: ...cmd
(Windows) orterminal
(Linux or MacOS) session in this folder. 1. An easy...(MAC_OS)
[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e option based on your OS. 3. For Our Open Source Contributor Software Developers: ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~98-~98: The operating system from Apple is written “macOS”.
Context: ...node.js` packages in Windows, Linux and MacOS. 1. For Windows: 1. first install ...(MAC_OS)
[duplication] ~112-~112: Possible typo: you repeated a word
Context: ... 5. Save the document. 6. Exitnotepad
7. Exit PowerShell 8. This will ens...(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~114-~114: Possible missing comma found.
Context: ...ou are always using the correct version ofnode.js
2. For Linux and MacOS, use t...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~115-~115: The operating system from Apple is written “macOS”.
Context: ...t version ofnode.js
2. For Linux and MacOS, use the terminal window. 1. install...(MAC_OS)
[grammar] ~119-~119: The word “setup” is a noun. The verb is spelled with a white space.
Context: ... the respective recommended commands to setup your node environment 3. This ...(NOUN_VERB_CONFUSION)
[uncategorized] ~158-~158: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...(COMMA_COMPOUND_SENTENCE)
[uncategorized] ~158-~158: Possible missing comma found.
Context: ...ve to create it. For a sample of.env
file there is a file named.env.example
in...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~199-~199: Possible missing preposition found.
Context: ... For additional details, please refer theHow to Access the Talawa-API URL
sect...(AI_HYDRA_LEO_MISSING_TO)
[grammar] ~203-~203: The word “setup” is a noun. The verb is spelled with a space.
Context: ...E_KEY in .env file You may not want to setup reCAPTCHA since the project will still ...(NOUN_VERB_CONFUSION)
[grammar] ~207-~207: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ad the following steps. If you want to setup Google reCAPTCHA now, you may refer to ...(NOUN_VERB_CONFUSION)
[uncategorized] ~209-~209: Possible missing comma found.
Context: ... service you set up duringtalawa-api
installation as shown in this screenshot: ![reCAPTC...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~221-~221: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...(MD_PRP_QUESTION_MARK)
[uncategorized] ~236-~236: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By defaulttalawa-admin
runs on port `4321` on y...(BY_DEFAULT_COMMA)
[grammar] ~286-~286: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...(PRP_MD_NN)
Markdownlint
DOCUMENTATION.md
25-25: null
Bare URL used(MD034, no-bare-urls)
PR_GUIDELINES.md
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CODE_STYLE.md
128-128: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
164-164: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
165-165: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
166-166: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
57-57: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
73-73: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
75-75: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
92-92: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
190-190: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
230-230: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
58-58: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
65-65: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
78-78: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
95-95: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
158-158: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
173-173: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
181-181: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
251-251: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CONTRIBUTING.md
104-104: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
113-113: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
128-128: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
139-139: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
143-143: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
158-158: null
No empty links(MD042, no-empty-links)
159-159: null
No empty links(MD042, no-empty-links)
161-161: null
No empty links(MD042, no-empty-links)
INSTALLATION.md
296-296: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
32-32: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
33-33: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
91-91: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
101-101: null
Bare URL used(MD034, no-bare-urls)
138-138: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
150-150: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
160-160: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
183-183: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
189-189: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
195-195: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
215-215: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
231-231: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
267-267: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
275-275: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
288-288: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
302-302: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
310-310: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
173-173: Expected: #setting-up-react_app_talawa_url-in-env-file; Actual: #setting-up-REACT_APP_TALAWA_URL-in-env-file
Link fragments should be valid(MD051, link-fragments)
173-173: Expected: #setting-up-react_app_recaptcha_site_key-in-env-file; Actual: #setting-up-REACT_APP_RECAPTCHA_SITE_KEY-in-env-file
Link fragments should be valid(MD051, link-fragments)
Additional comments not posted (218)
.prettierrc (1)
2-3
: LGTM! The configuration change enhances cross-environment compatibility.The addition of
"endOfLine": "auto"
allows Prettier to adapt to different line endings automatically, which is beneficial for collaboration across various operating systems. The existing preference for single quotes remains intact..husky/pre-commit (1)
1-10
: LGTM! The pre-commit hook effectively enforces code quality checks.The setup runs linting, type-checking, and updates the table of contents before commits, which helps maintain code quality. Consider uncommenting the
format:fix
andlint:fix
commands if automatic fixing is desired during pre-commit.src/Constant/constant.ts (2)
1-1
: Avoid using empty strings for sensitive constants.The
AUTH_TOKEN
is initialized as an empty string. If this is intended for sensitive data, ensure it is securely managed and not left empty in production.
2-5
: Ensure environment variables are defined.The constants are relying on environment variables. Verify that these variables are defined in all environments where the application runs to avoid runtime errors.
.coderabbit.yaml (4)
5-5
: Consider the impact of the "chill" review profile.The "chill" profile may affect the thoroughness of reviews. Ensure this aligns with the project's review standards.
6-6
: Review the implications of enablingrequest_changes_workflow
.Ensure that enabling
request_changes_workflow
aligns with your team's workflow and doesn't introduce unnecessary bottlenecks.
12-15
: Ensurebase_branches
are correctly specified.Verify that the specified base branches align with your development workflow to prevent issues with auto-reviews.
16-17
: Assess the necessity ofauto_reply
.Consider whether enabling
auto_reply
for chat aligns with your communication practices and doesn't lead to misunderstandings.public/manifest.json (2)
13-13
: Verify the change in icon size.The size for
logo192.png
has been changed to "16x16". Ensure this is intentional as it may affect the display quality of the icon.
16-16
: Confirm the updated image path.The path for
logo512.png
has been updated toimages/logo512.png
. Ensure this path is correct and the image is accessible.Verification successful
Image path verified successfully.
The image
logo512.png
exists at the pathpublic/images/logo512.png
, confirming that the path specified in themanifest.json
file is correct and the image is accessible.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the updated image path. # Test: Check if the image file exists at the specified path. fd 'logo512.png' --exec echo 'Image exists at: {}'Length of output: 95
.gitignore (1)
Line range hint
3-37
:
LGTM! Improved file management.The additions to the
.gitignore
file enhance the management of ignored files, ensuring that unnecessary files are not tracked in the version control system.scripts/config-overrides/custom_build.js (1)
1-16
: LGTM! Conditional build script.The custom build script effectively uses environment variables to switch between build configurations. Ensure that the
ALLOW_LOGS
environment variable is correctly set in the deployment environment.Verification successful
Environment Variable Documentation Found
The
ALLOW_LOGS
environment variable is documented inINSTALLATION.md
, providing instructions on how to set it for logging purposes. This ensures users are informed about its correct usage in the deployment environment.
INSTALLATION.md
: Instructions for settingALLOW_LOGS
.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the ALLOW_LOGS environment variable in the codebase. # Test: Search for the environment variable usage. Expect: Occurrences in configuration or deployment scripts. rg --type js --type sh 'ALLOW_LOGS'Length of output: 197
Script:
#!/bin/bash # Description: Search for documentation or deployment scripts mentioning ALLOW_LOGS. # Look for mentions of ALLOW_LOGS in markdown and YAML files, which might contain documentation or deployment configurations. rg 'ALLOW_LOGS' --type md --type yamlLength of output: 220
src/GraphQl/Queries/ActionItemCategoryQueries.ts (1)
1-18
: LGTM! Well-structured GraphQL query.The GraphQL query is well-defined and the JSDoc comment provides clear documentation for its purpose and parameters.
scripts/custom-test-env.js (1)
1-16
: LGTM! Custom Jest environment setup is well-implemented.The custom environment correctly extends
jest-environment-jsdom
and sets upTextEncoder
andTextDecoder
as needed for testing with@pdfme
.scripts/config-overrides/custom_start.js (1)
1-18
: LGTM! Script for starting React app is well-structured.The script effectively uses environment variables to determine which start command to run, and the use of
spawn
withstdio: 'inherit'
is appropriate for displaying output.src/GraphQl/Queries/AgendaCategoryQueries.ts (1)
10-22
: Query Structure Looks Good.The GraphQL query
AGENDA_ITEM_CATEGORY_LIST
is well-structured and correctly uses the$organizationId
variable to fetch agenda item categories. Ensure that the backend schema supports this query structure.public/locales/sp/errors.json (1)
1-10
: Translations Appear Accurate.The Spanish translations for error messages are consistent with their English counterparts and seem accurate. Ensure that these messages are correctly integrated into the application.
src/GraphQl/Mutations/AgendaItemMutations.ts (3)
3-9
: Create Mutation Structure Looks Good.The
CREATE_AGENDA_ITEM_MUTATION
is well-structured, using$input
as a variable for creating agenda items. Ensure that theCreateAgendaItemInput
type is correctly defined in the backend schema.
12-18
: Delete Mutation Structure Looks Good.The
DELETE_AGENDA_ITEM_MUTATION
correctly uses$removeAgendaItemId
to identify the agenda item to be removed. Ensure that the backend supports this mutation and handles errors appropriately.
20-30
: Update Mutation Structure Looks Good.The
UPDATE_AGENDA_ITEM_MUTATION
uses$updateAgendaItemId
and$input
to update agenda items. Ensure that theUpdateAgendaItemInput
type is correctly defined and that the mutation handles all necessary fields.scripts/config-overrides/index.js (1)
7-20
: Verify ProgressPlugin configuration values.The
modulesCount
anddependenciesCount
values are set to 5000 and 10000, respectively. Ensure these values are suitable for your project's scale to avoid potential performance issues.src/Constant/constant.spec.ts (4)
9-12
: Test forAUTH_TOKEN
is correct.The test correctly verifies that
AUTH_TOKEN
is an empty string.
14-16
: Test forBACKEND_URL
is correct.The test correctly verifies that
BACKEND_URL
matches theREACT_APP_TALAWA_URL
environment variable. Ensure this variable is set during test execution.
18-22
: Test forRECAPTCHA_SITE_KEY
is correct.The test correctly verifies that
RECAPTCHA_SITE_KEY
matches theREACT_APP_RECAPTCHA_SITE_KEY
environment variable. Ensure this variable is set during test execution.
24-28
: Test forREACT_APP_USE_RECAPTCHA
is correct.The test correctly verifies that
REACT_APP_USE_RECAPTCHA
matches the corresponding environment variable. Ensure this variable is set during test execution.public/index.html (2)
5-8
: Favicon and apple-touch-icon updates are correct.The updates to the favicon and apple-touch-icon links are appropriate and align with the project's branding.
10-15
: Google Fonts preconnect and stylesheet are correct.The addition of preconnect links and the new font stylesheet improves loading performance and typography.
src/GraphQl/Mutations/ActionItemCategoryMutations.ts (2)
10-16
: LGTM! Ensure input validation and error handling.The
CREATE_ACTION_ITEM_CATEGORY_MUTATION
is correctly defined. Ensure that input validation and error handling are handled upstream.
26-39
: LGTM! Ensure input validation and error handling.The
UPDATE_ACTION_ITEM_CATEGORY_MUTATION
is correctly structured. Ensure that input validation and error handling are handled upstream.src/assets/scss/_general.scss (5)
1-9
: LGTM!The
:root
and global resets are well-defined and follow best practices.
11-17
: LGTM!The
html
andbody
styles are appropriate for a responsive layout.
19-22
: LGTM!The
#root
styles ensure full viewport height and a consistent background.
24-32
: LGTM!The input and form styles enhance accessibility and user experience.
34-63
: LGTM!The
shimmer
animation is well-defined and follows best practices for a loading effect..github/workflows/codeql-codescan.yml (3)
14-20
: LGTM!The workflow triggers are correctly configured for comprehensive code scanning on pull requests and pushes.
21-28
: LGTM!The job configuration is appropriate for CodeQL analysis, using a matrix strategy for JavaScript.
29-43
: LGTM!The job steps are correctly ordered and configured for CodeQL analysis.
src/GraphQl/Mutations/AgendaCategoryMutations.ts (3)
9-15
: LGTM!The
CREATE_AGENDA_ITEM_CATEGORY_MUTATION
is well-defined and uses appropriate GraphQL syntax.
23-27
: LGTM!The
DELETE_AGENDA_ITEM_CATEGORY_MUTATION
is correctly implemented for deleting an agenda category by ID.
36-45
: LGTM!The
UPDATE_AGENDA_ITEM_CATEGORY_MUTATION
is well-structured and correctly updates an agenda category.src/GraphQl/Mutations/CommentMutations.ts (3)
11-28
: LGTM!The
CREATE_COMMENT_POST
mutation is well-defined and returns detailed information about the created comment.
37-43
: LGTM!The
LIKE_COMMENT
mutation is correctly implemented for liking a comment by ID.
52-58
: LGTM!The
UNLIKE_COMMENT
mutation is correctly implemented for unliking a comment by ID.src/GraphQl/Queries/AgendaItemQueries.ts (2)
3-37
: LGTM!The
AgendaItemByOrganization
query is well-structured and retrieves comprehensive details about agenda items.
39-73
: LGTM!The
AgendaItemByEvent
query is well-structured and retrieves comprehensive details about agenda items..github/workflows/issue.yml (3)
12-12
: Workflow Name UpdateThe workflow name has been updated to "Issue Workflow," reflecting its broader purpose beyond just auto-labeling.
27-34
: New Job: Issue-GreetingA new job "Issue-Greeting" has been added to send a greeting message to users when they create their first issue. This enhances user engagement by providing immediate feedback and resources.
17-21
: Job Renaming and Action Version UpdateThe job "build" has been renamed to "Opened-issue-label," which more accurately describes its function. Additionally, the
auto-label
action has been upgraded to versionv2.3.0
. Ensure that this version is compatible and does not introduce any breaking changes.scripts/test.js (1)
3-52
: Environment Setup and Jest ExecutionThe script correctly sets up the environment for testing and handles unhandled promise rejections, which is a good practice. It also ensures tests are watched unless on CI, which is efficient for local development.
src/GraphQl/Mutations/EventAttendeeMutations.ts (1)
1-49
: GraphQL Mutations for Event ManagementThe GraphQL mutations for adding, removing, and checking in attendees are well-defined and documented. The code is clear and follows best practices for GraphQL.
.github/pull_request_template.md (1)
Line range hint
1-53
:
Improved Clarity and Guidelines in PR Template.The restructuring of the pull request template enhances clarity and ensures contributors follow best practices. The emphasis on submitting PRs against the
develop
branch and the inclusion of prompts for issue linking and documentation updates are particularly beneficial.src/assets/scss/components/_accordion.scss (3)
1-7
: Ensure CSS variable compatibility.The SCSS variables are being used with CSS variables. Ensure that the
$prefix
variable is defined and that the CSS variables are supported in the environments where this code will be used.
8-11
: Consider simplifying border radius calculation.The
subtract
function is used to calculate the inner border radius. Ensure that this function is defined and works as expected in your SCSS setup.
35-36
: Verify SVG usage in data URIs.The SVG icons are embedded as data URIs. Ensure that these icons render correctly across all supported browsers.
.github/workflows/push.yml (3)
19-20
: Ensure uniqueness of environment variables.The
CODECOV_UNIQUE_NAME
environment variable is constructed usinggithub.run_id
andgithub.run_number
. Verify that this naming strategy meets your requirements for uniqueness and traceability.
34-48
: Review caching strategy for node modules.The caching strategy uses
actions/cache
with a key based on the OS andpackage-lock.json
. Ensure this approach effectively reduces build times and consider the implications of cache invalidation.
52-52
: Confirm test command compatibility.The test command
npm run test -- --watchAll=false --coverage
should be compatible with the project setup. Ensure that this command works as expected and produces the necessary coverage reports..github/workflows/stale.yml (1)
37-38
: Evaluate timing for stale and close actions.The configuration marks issues and PRs as stale after 10 days and closes them after 180 days. Verify that these timeframes are appropriate for your project's workflow.
jest.config.js (1)
1-67
: Ensure compatibility with the latest Jest version.This Jest configuration file is comprehensive and seems well-structured for a React-based project. Ensure that all configurations are compatible with the latest versions of
jest
and@types/jest
as per the PR objectives.
- Roots and Coverage: The
roots
andcollectCoverageFrom
settings are standard for focusing on thesrc
directory. Ensure the paths are correct and reflect the project's structure.- Setup Files: The
setupFiles
andsetupFilesAfterEnv
are correctly set for initializing the test environment. Verify that the specified files exist and are correctly configured.- Transformations: The
transform
andtransformIgnorePatterns
settings are crucial for handling various file types. Ensure that the paths to the transformation scripts are correct and compatible with the new Jest version.- Module Paths and Mappers: The
modulePaths
andmoduleNameMapper
settings are used for resolving modules. Ensure that these paths are valid and that any mocked modules are correctly set up.- Coverage and Test Path Patterns: The
coveragePathIgnorePatterns
andtestPathIgnorePatterns
settings are used to exclude specific files from coverage and testing. Ensure these patterns are accurate and reflect the project's testing strategy.Overall, the configuration looks good, but you should verify that all specified paths and scripts are updated and compatible with the latest Jest version.
src/GraphQl/Mutations/PledgeMutation.ts (3)
14-36
: Ensure alignment with the GraphQL schema for creating pledges.The
CREATE_PLEDGE
mutation appears well-structured, but ensure that the types and fields align with your GraphQL schema. Verify that theCurrency
andDate
scalar types are correctly defined in your schema, and consider validating theuserIds
array to ensure it contains valid IDs.
78-84
: Ensure alignment with the GraphQL schema for deleting pledges.The
DELETE_PLEDGE
mutation is straightforward. Ensure that theremoveFundraisingCampaignPledge
mutation is correctly defined in your schema and that it returns the expected fields.Verification successful
Mutation Alignment Verified with GraphQL Schema
The
removeFundraisingCampaignPledge
mutation is correctly defined and returns the expected_id
field, aligning with theDELETE_PLEDGE
mutation's requirements. No further issues were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and correctness of DELETE_PLEDGE mutation. # Test: Check for the definition of removeFundraisingCampaignPledge mutation. Expect: Mutation is defined. rg --type graphql 'mutation removeFundraisingCampaignPledge'Length of output: 94
Script:
#!/bin/bash # Locate GraphQL schema files and search for the removeFundraisingCampaignPledge mutation definition. # Find GraphQL schema files and search for the mutation definition. fd --extension graphql --extension gql --exec rg 'removeFundraisingCampaignPledge' {}Length of output: 87
Script:
#!/bin/bash # Search for the removeFundraisingCampaignPledge mutation in JavaScript and TypeScript files. # Find JavaScript and TypeScript files and search for the mutation definition. fd --extension js --extension ts --exec rg 'removeFundraisingCampaignPledge' {}Length of output: 214
Script:
#!/bin/bash # Extract more context around occurrences of the removeFundraisingCampaignPledge mutation to verify its definition and returned fields. # Search for the mutation definition and show surrounding lines for context. fd --extension js --extension ts --exec rg 'removeFundraisingCampaignPledge' -A 5 -B 5 {}Length of output: 674
48-70
: Ensure alignment with the GraphQL schema for updating pledges.The
UPDATE_PLEDGE
mutation is flexible, allowing optional updates to fields. Ensure that theusers
field is correctly handled in your schema and that partial updates are supported. Verify that the mutation aligns with your GraphQL schema.src/GraphQl/Mutations/FundMutation.ts (3)
49-71
: Correct the spelling ofrefrenceNumber
.The
UPDATE_FUND_MUTATION
mutation contains a typo in the field namerefrenceNumber
. It should bereferenceNumber
to maintain consistency and readability.- $refrenceNumber: String + $referenceNumber: StringEnsure that this change is reflected throughout the mutation and in your GraphQL schema.
#!/bin/bash # Description: Verify the existence and correctness of UPDATE_FUND_MUTATION mutation. # Test: Check for the definition of updateFund mutation. Expect: Mutation is defined. rg --type graphql 'mutation updateFund'
14-36
: Correct the spelling ofrefrenceNumber
.The
CREATE_FUND_MUTATION
mutation contains a typo in the field namerefrenceNumber
. It should bereferenceNumber
to maintain consistency and readability.- $refrenceNumber: String + $referenceNumber: StringEnsure that this change is reflected throughout the mutation and in your GraphQL schema.
79-85
: Ensure alignment with the GraphQL schema for removing funds.The
REMOVE_FUND_MUTATION
mutation is straightforward. Ensure that theremoveFund
mutation is correctly defined in your schema and that it returns the expected fields.src/GraphQl/Mutations/ActionItemMutations.ts (6)
3-11
: Documentation is clear and informative.The documentation for the
CREATE_ACTION_ITEM_MUTATION
is well-written and provides a clear understanding of the parameters involved.
35-45
: Documentation is clear and informative.The documentation for the
UPDATE_ACTION_ITEM_MUTATION
is well-written and provides a clear understanding of the parameters involved.
73-77
: Documentation is clear and informative.The documentation for the
DELETE_ACTION_ITEM_MUTATION
is concise and provides a clear understanding of the parameters involved.
13-33
: Ensure input validation and error handling.While the mutation is well-structured, ensure that input validation and error handling are implemented in the resolver to prevent invalid data from being processed.
47-71
: Ensure input validation and error handling.While the mutation is well-structured, ensure that input validation and error handling are implemented in the resolver to prevent invalid data from being processed.
79-85
: Ensure input validation and error handling.While the mutation is well-structured, ensure that input validation and error handling are implemented in the resolver to prevent invalid data from being processed.
src/GraphQl/Mutations/CampaignMutation.ts (6)
3-13
: Documentation is clear and informative.The documentation for the
CREATE_CAMPAIGN_MUTATION
is well-written and provides a clear understanding of the parameters involved.
41-51
: Documentation is clear and informative.The documentation for the
UPDATE_CAMPAIGN_MUTATION
is well-written and provides a clear understanding of the parameters involved.
77-82
: Documentation is clear and informative.The documentation for the
DELETE_CAMPAIGN_MUTATION
is concise and provides a clear understanding of the parameters involved.
83-89
: Ensure input validation and error handling.While the mutation is well-structured, ensure that input validation and error handling are implemented in the resolver to prevent invalid data from being processed.
15-39
: Ensure input validation and error handling.While the mutation is well-structured, ensure that input validation and error handling are implemented in the resolver to prevent invalid data from being processed.
53-75
: Ensure input validation and error handling.While the mutation is well-structured, ensure that input validation and error handling are implemented in the resolver to prevent invalid data from being processed.
src/GraphQl/Queries/ActionItemQueries.ts (3)
3-13
: Documentation is clear and informative.The documentation for the
ACTION_ITEM_LIST
query is well-written and provides a clear understanding of the parameters involved.
15-66
: Ensure efficient data retrieval.The query is well-structured, but ensure that the database or backend service is optimized to handle potentially large datasets efficiently.
68-103
: Ensure efficient data retrieval.The query is well-structured, but ensure that the database or backend service is optimized to handle potentially large datasets efficiently.
public/locales/en/common.json (1)
1-86
: Localization file addition approved.The English localization file is well-structured and complete.
public/locales/sp/common.json (1)
1-86
: Localization file addition approved.The Spanish localization file is well-structured and complete.
scripts/githooks/check-localstorage-usage.js (1)
1-95
: LocalStorage usage check script approved.The script is well-structured and effectively checks for
localStorage
usage in modified files. It handles errors and allows skipping specific files.src/GraphQl/Queries/fundQueries.ts (4)
11-37
: LGTM!The
FUND_LIST
query is well-structured and follows GraphQL best practices.
39-56
: LGTM!The
FUND_CAMPAIGN
query is well-structured and follows GraphQL best practices.
58-84
: LGTM!The
FUND_CAMPAIGN_PLEDGE
query is well-structured and follows GraphQL best practices.
102-127
: LGTM!The
USER_PLEDGES
query is well-structured and follows GraphQL best practices.public/locales/fr/common.json (1)
1-86
: LGTM!The French translations are accurate and consistent with the English terms.
ISSUE_GUIDELINES.md (1)
1-1
: Fix punctuation issue.Remove the punctuation mark at the start of the line.
-# Issue Report Guidelines +# Issue Report GuidelinesLikely invalid or redundant comment.
src/App.test.tsx (4)
2-13
: Ensure all necessary imports are present.The imports for Redux, Apollo Client, and internationalization are correctly included for the test setup. The mock for
PieChart
is implemented to bypass rendering issues, which is a good practice for isolated testing.
61-67
: Utility functionwait
is correctly implemented.The
wait
function usesact
to manage asynchronous operations, which is essential for reliable test execution. This is a good practice for handling asynchronous tasks in tests.
69-94
: Logged-in user test case is well-structured.The test case for a logged-in user verifies rendering and navigation, ensuring the component behaves as expected. Consider adding assertions for more UI elements if necessary.
25-56
: Verify mock data comprehensiveness.The mock data for
CHECK_AUTH
appears comprehensive, covering various user attributes. Ensure this data is representative of real-world scenarios to maintain test reliability.Verification successful
Mock Data for
CHECK_AUTH
is ComprehensiveThe
CHECK_AUTH
query is used extensively in the codebase, including in application logic and tests. The mock data provided for this query is comprehensive and covers a wide range of user attributes, aligning well with its usage. This ensures reliable and effective testing.
- Files Involved:
src/App.tsx
src/screens/UserPortal/Settings/Settings.tsx
src/App.test.tsx
src/screens/UserPortal/Settings/Settings.test.tsx
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of CHECK_AUTH query in the codebase to ensure the mock data is comprehensive. # Test: Search for CHECK_AUTH query usage. Expect: Consistent usage patterns across the codebase. rg --type graphql 'query CHECK_AUTH'Length of output: 70
Script:
#!/bin/bash # Description: Search for the usage of CHECK_AUTH in JavaScript and TypeScript files. # Test: Search for CHECK_AUTH query usage in JavaScript and TypeScript files. rg 'CHECK_AUTH' --type js --type tsLength of output: 929
.github/workflows/pull-request-target.yml (2)
12-14
: Workflow trigger is appropriate.The
pull_request_target
event is correctly used to trigger the workflow, allowing it to run in the context of the base repository.
21-68
: Review policy and greeting steps are well-configured.The steps for adding a PR review policy comment and sending a greeting message are correctly configured. The messages are clear and informative, guiding contributors effectively.
README.md (4)
3-3
: Community engagement link added.The Slack community link is a valuable addition, promoting interaction among users and contributors.
5-5
: Logo update enhances branding.The updated logo source improves visual branding. Ensure the image is accessible and correctly displayed.
24-32
: Table of Contents improves navigation.The addition of a Table of Contents enhances document navigation, making it easier for users to find relevant sections.
45-51
: Documentation and setup instructions are clear.The updated documentation links and reformatted setup instructions improve clarity and accessibility. Ensure all links are functional and lead to the correct resources.
.github/workflows/eslint_disable_check.py (4)
29-41
: LGTM!The
has_eslint_disable
function is correctly implemented to check foreslint-disable
statements using regex.
43-68
: LGTM!The
check_eslint
function effectively checks foreslint-disable
statements in TypeScript files within the specified directory.
70-84
: LGTM!The
arg_parser_resolver
function is well-implemented for parsing command-line arguments.
86-117
: LGTM!The
main
function is well-structured and handles the script's main logic effectively..eslintrc.json (3)
Line range hint
4-16
: Environment and Extends Configuration UpdatesThe addition of the Node environment and the extended configurations enhance the linting capabilities and are aligned with best practices.
32-39
: Plugin Additions Enhance LintingThe addition of plugins for import management, TSDoc, and Prettier improves code quality and consistency.
Line range hint
41-140
: Rules Enhancements for Code QualityThe updated rules enhance code quality by enforcing stricter standards and promoting consistency, especially for TypeScript and React.
package.json (4)
2-6
: Metadata and Configuration UpdatesThe updates to the project name, version, and type are appropriate for a major release, reflecting significant improvements.
8-59
: Dependencies OverhaulThe updated dependencies enhance functionality and align with modern development practices.
62-76
: Scripts RestructuringThe restructured scripts improve the development workflow by enhancing linting, formatting, and type checking processes.
97-147
: DevDependencies and Configuration EnhancementsThe updates to devDependencies and the addition of resolutions and engines enhance tooling and ensure compatibility with required environments.
.github/workflows/compare_translations.py (4)
63-89
: LGTM!The
compare_translations
function is well-structured and effectively identifies missing or mismatched keys between translations.
92-109
: LGTM!The
load_translation
function correctly handles file reading and JSON decoding, including error handling for empty files and JSON errors.
112-156
: LGTM!The
check_translations
function is well-implemented, efficiently checking for missing translations and handling errors appropriately.
159-186
: LGTM!The
main
function effectively handles command-line argument parsing and directory validation before invokingcheck_translations
.src/GraphQl/Mutations/OrganizationMutations.ts (9)
12-26
: LGTM!The
UPDATE_USER_ROLE_IN_ORG_MUTATION
is well-defined with clear documentation and appropriate parameters.
34-38
: LGTM!The
CREATE_SAMPLE_ORGANIZATION_MUTATION
is simple and correctly defined, with clear documentation.
46-50
: LGTM!The
REMOVE_SAMPLE_ORGANIZATION_MUTATION
is simple and correctly defined, with clear documentation.
60-76
: LGTM!The
CREATE_GROUP_CHAT
mutation is well-defined with clear documentation and appropriate parameters.
78-86
: LGTM!The
CREATE_DIRECT_CHAT
mutation is well-defined with clear documentation and appropriate parameters.
88-107
: LGTM!The
SEND_MESSAGE_TO_DIRECT_CHAT
mutation is well-defined with clear documentation and appropriate parameters.
109-123
: LGTM!The
SEND_MESSAGE_TO_GROUP_CHAT
mutation is well-defined with clear documentation and appropriate parameters.
125-141
: LGTM!The
CREATE_MESSAGE_CHAT
mutation is well-defined with clear documentation and appropriate parameters.
211-217
: LGTM!The
TOGGLE_PINNED_POST
mutation is well-defined with clear documentation and an appropriate parameter.src/GraphQl/Queries/OrganizationQueries.ts (8)
15-72
: LGTM!The
ORGANIZATION_POST_LIST
query is well-defined with clear documentation and appropriate parameters for pagination.
74-110
: LGTM!The
ORGANIZATION_ADVERTISEMENT_LIST
query is well-defined with clear documentation and appropriate parameters for pagination.
122-169
: LGTM!The
USER_ORGANIZATION_CONNECTION
query is well-defined with clear documentation and appropriate parameters for filtering and pagination.
178-207
: LGTM!The
USER_JOINED_ORGANIZATIONS
query is well-defined with clear documentation and an appropriate parameter.
216-245
: LGTM!The
USER_CREATED_ORGANIZATIONS
query is well-defined with clear documentation and an appropriate parameter.
254-267
: LGTM!The
ORGANIZATION_ADMINS_LIST
query is well-defined with clear documentation and an appropriate parameter.
275-289
: LGTM!The
ORGANIZATION_FUNDS
query is well-defined with clear documentation and an appropriate parameter.
297-320
: LGTM!The
VENUE_LIST
query is well-defined with clear documentation and appropriate parameters for filtering and pagination.src/GraphQl/Queries/PlugInQueries.ts (10)
9-19
: LGTM!The
PLUGIN_GET
query is well-structured and retrieves the necessary plugin details.
27-45
: LGTM!The
ADVERTISEMENTS_GET
query is well-structured and retrieves the necessary advertisement details.
59-100
: LGTM!The
ORGANIZATION_EVENTS_CONNECTION
query is well-structured and uses filters effectively to retrieve event details.
111-133
: LGTM!The
DIRECT_CHAT_MESSAGES_BY_CHAT_ID
query is well-structured and retrieves the necessary chat message details.
135-167
: LGTM!The
DIRECT_CHAT_BY_ID
query is well-structured and retrieves the necessary chat and user details.
169-196
: LGTM!The
GROUP_CHAT_BY_ID
query is well-structured and retrieves the necessary group chat details.
222-262
: LGTM!The
DIRECT_CHATS_LIST
query is well-structured and retrieves the necessary direct chat details.
264-299
: LGTM!The
GROUP_CHAT_LIST
query is well-structured and retrieves the necessary group chat details.
307-311
: LGTM!The
IS_SAMPLE_ORGANIZATION_QUERY
is well-structured and retrieves the necessary boolean result.
320-328
: LGTM!The
ORGANIZATION_CUSTOM_FIELDS
query is well-structured and retrieves the necessary custom field details..github/workflows/countline.py (5)
35-56
: LGTM!The
_valid_filename
function is correctly implemented and checks for invalid filenames efficiently.
58-79
: LGTM!The
_valid_extension
function is correctly implemented and checks for invalid extensions efficiently.
81-120
: LGTM!The
_valid_exclusions
function is correctly implemented and efficiently generates a list of file paths to exclude.
122-142
: LGTM!The
_filepaths_in_directories
function is correctly implemented and efficiently generates file paths from directories.
145-195
: LGTM!The
_arg_parser_resolver
function is correctly implemented and efficiently parses command-line arguments..github/workflows/pull-request.yml (7)
23-77
: LGTM!The
Code-Quality-Checks
job is well-structured and covers essential code quality checks efficiently.
79-120
: LGTM!The
Check-Unauthorized-Changes
job is well-structured and effectively checks for unauthorized file changes.
121-148
: LGTM!The
Count-Changed-Files
job is well-structured and effectively checks if the number of changed files is acceptable.
149-164
: LGTM!The
Check-ESlint-Disable
job is well-structured and effectively checks for the use ofeslint-disable
.
165-210
: LGTM!The
Test-Application
job is well-structured and effectively runs tests and uploads coverage reports.
211-237
: LGTM!The
Graphql-Inspector
job is well-structured and effectively runs GraphQL introspection.
238-246
: LGTM!The
Check-Target-Branch
job is well-structured and effectively checks if the target branch isdevelop
.CODE_STYLE.md (4)
24-38
: Tech Stack section is well-defined.The section clearly lists the technologies used in the project.
40-45
: Component Structure section is clear and concise.The guidelines align with modern React practices.
118-122
: Test and Code Linting section is well-structured.The emphasis on testing and linting is appropriate for maintaining code quality.
185-253
: Customising Bootstrap section is informative and well-structured.The guidelines on customizing Bootstrap and compiling Sass files are clear.
Tools
Markdownlint
190-190: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
230-230: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
251-251: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
src/App.tsx (2)
1-45
: Import statements are well-organized.The imports are necessary for the new routing and authentication structure.
70-210
: Comprehensive routing setup inapp
function.The routing logic is well-structured and enhances application functionality.
However, verify the usage of the function name
app
across the codebase to ensure consistency.Verification successful
Function name
app
is consistently used.The function name
app
is only used insrc/App.tsx
, ensuring consistency across the codebase. No further action is necessary.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the function name `app` across the codebase. # Test: Search for the function name usage. Expect: Only occurrences of the new name. rg --type js --type ts -A 2 $'app'Length of output: 129652
CONTRIBUTING.md (2)
Line range hint
80-167
: Contributing Code section is detailed and informative.The guidelines provide a clear process for contributing code.
Tools
LanguageTool
[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...(MAC_OS)
[uncategorized] ~164-~164: Possible missing comma found.
Context: ...o add all changes). 1. After adding the changes you need to commit them using `git comm...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~165-~165: The past participle is required after “must be”.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...(BE_VBP_IN)
[uncategorized] ~167-~167: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...(ON_SKYPE)
Markdownlint
104-104: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
113-113: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
128-128: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
139-139: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
143-143: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
158-158: null
No empty links(MD042, no-empty-links)
159-159: null
No empty links(MD042, no-empty-links)
161-161: null
No empty links(MD042, no-empty-links)
170-172
: Internships section is concise and informative.The section provides clear guidance on internships.
INSTALLATION.md (1)
5-35
: Table of Contents looks good.The structure and links in the Table of Contents are well-organized and provide a clear overview of the document.
Tools
LanguageTool
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...(ENGLISH_WORD_REPEAT_RULE)
Markdownlint
32-32: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
33-33: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
src/GraphQl/Queries/Queries.ts (10)
5-29
: QueryCHECK_AUTH
looks good.The query structure is correct, and the fields retrieved are appropriate for authentication checks.
32-61
: QueryORGANIZATION_LIST
looks good.The query structure is correct, and the fields retrieved are appropriate for listing organizations.
64-103
: QueryORGANIZATION_CONNECTION_LIST
looks good.The query structure is correct, and the fields retrieved are appropriate for listing organizations with filtering and sorting options.
106-201
: QueryUSER_LIST
looks good.The query structure is correct, and the fields retrieved are appropriate for listing users with filtering options.
202-220
: QueryUSER_LIST_FOR_TABLE
looks good.The query structure is correct, and the fields retrieved are appropriate for displaying users in a table format.
222-263
: QueryUSER_LIST_REQUEST
looks good.The query structure is correct, and the fields retrieved are appropriate for listing users with additional profile details.
265-290
: QueryEVENT_DETAILS
looks good.The query structure is correct, and the fields retrieved are appropriate for fetching event details, including attendees and organization members.
292-302
: QueryEVENT_ATTENDEES
looks good.The query structure is correct, and the fields retrieved are appropriate for listing event attendees.
304-322
: QueryEVENT_CHECKINS
looks good.The query structure is correct, and the fields retrieved are appropriate for fetching check-in status of event attendees.
324-336
: QueryEVENT_FEEDBACKS
looks good.The query structure is correct, and the fields retrieved are appropriate for fetching event feedback, including scores and reviews.
src/GraphQl/Mutations/mutations.ts (10)
3-9
: MutationUNBLOCK_USER_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for unblocking a user.
13-19
: MutationBLOCK_USER_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for blocking a user.
23-29
: MutationREJECT_ORGANIZATION_REQUEST_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for rejecting a membership request.
33-39
: MutationACCEPT_ORGANIZATION_REQUEST_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for accepting a membership request.
43-67
: MutationUPDATE_ORGANIZATION_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for updating organization details.
85-121
: MutationUPDATE_USER_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for updating user profile details.
125-143
: MutationUPDATE_USER_PASSWORD_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for updating a user's password.
147-171
: MutationSIGNUP_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for handling user signup.
175-197
: MutationLOGIN_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for handling user login.
200-207
: MutationREFRESH_TOKEN_MUTATION
looks good.The mutation structure is correct, and the fields involved are appropriate for refreshing authentication tokens.
public/locales/zh/translation.json (1)
1-1010
: Translations look good!The translations provided in this file appear to be accurate and consistent. They cover a wide range of UI elements and messages.
schema.graphql (1)
1-1584
: GraphQL schema looks well-defined!The schema definitions are comprehensive and appear to follow best practices. The types, inputs, and enums are well-structured and consistent.
public/locales/en/translation.json (7)
43-46
: Section approved.The translations for
latestEvents
are clear and consistent.
48-51
: Section approved.The translations for
latestPosts
are clear and consistent.
53-54
: Section approved.The translation for
listNavbar
is clear and consistent.
56-59
: Section approved.The translations for
leftDrawer
are clear and consistent.
61-78
: Section approved.The translations for
leftDrawerOrg
are clear and consistent.
110-112
: Section approved.The translations for
orgListCard
are clear and consistent.
114-116
: Section approved.The translations for
paginationList
are clear and consistent.public/locales/hi/translation.json (8)
43-46
: Translations look good!The translations for the
latestEvents
section are accurate and consistent.
48-51
: Translations look good!The translations for the
latestPosts
section are accurate and consistent.
53-54
: Translation looks good!The translation for "roles" is accurate.
56-59
: Translations look good!The translations for the
leftDrawer
section are accurate and consistent.
61-78
: Translations look good!The translations for the
leftDrawerOrg
section are accurate and consistent.
80-108
: Translations look good!The translations for the
orgList
section are accurate and consistent.
110-112
: Translations look good!The translations for the
orgListCard
section are accurate and consistent.
114-116
: Translations look good!The translations for the
paginationList
section are accurate and consistent.public/locales/fr/translation.json (16)
54-54
: Translation Accuracy for "Les rôles".The translation "Les rôles" is accurate for "Roles". No changes needed.
57-59
: Translation Consistency for "Mes organisations" and "Profil de la communauté".Ensure consistent translation style across similar navigation items. The translations appear accurate and consistent.
62-78
: Translation Consistency for Organization Navigation Items.The translations for organization-related navigation items are accurate and consistent. No changes needed.
81-108
: Translation Completeness and Consistency for Organization List.The translations for the organization list are complete and consistent with the context. No changes needed.
111-112
: Translation Accuracy for "Gérer" and "Exemple d'organisation".The translations for managing organizations are accurate. No changes needed.
115-116
: Translation Accuracy for Pagination Controls.The translations for pagination controls are accurate. No changes needed.
119-129
: Translation Completeness and Consistency for Membership Requests.The translations for membership requests are complete and consistent. No changes needed.
132-153
: Translation Completeness and Consistency for User Roles and Actions.The translations for user roles and actions are complete and consistent. No changes needed.
156-165
: Translation Accuracy for Community Profile Settings.The translations for community profile settings are accurate and consistent. No changes needed.
168-181
: Translation Completeness and Consistency for Dashboard Items.The translations for dashboard items are complete and consistent. No changes needed.
184-201
: Translation Completeness and Consistency for Organization Members.The translations for managing organization members are complete and consistent. No changes needed.
204-205
: Translation Accuracy for Adding Administrators.The translations for adding administrators are accurate. No changes needed.
208-211
: Translation Accuracy for Managing Administrators.The translations for managing administrators are accurate and consistent. No changes needed.
214-217
: Translation Accuracy for Managing Members.The translations for managing members are accurate. No changes needed.
220-248
: Translation Completeness and Consistency for Event Management.The translations for event management are complete and consistent. No changes needed.
251-284
: Translation Completeness and Consistency for Action Items.The translations for action items are complete and consistent. No changes needed.
CODE_OF_CONDUCT.md (2)
3-19
: Table of Contents addition looks good.The addition of the Table of Contents enhances the document's navigability and accessibility.
Tools
LanguageTool
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
11-11
: No typo in the Table of Contents.The repetition of the word "Enforcement" is intentional, as it refers to different sections. The static analysis hint can be ignored.
Tools
LanguageTool
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
setup.ts (1)
1-8
: Imports are appropriate for the setup process.The imported modules and functions are necessary for configuring the environment and handling user input.
import fs from 'fs'; | ||
import { execSync } from 'child_process'; | ||
|
||
const markdownFiles = fs | ||
.readdirSync('./') | ||
.filter((file) => file.endsWith('.md')); | ||
|
||
markdownFiles.forEach((file) => { | ||
const command = `markdown-toc -i "${file}" --bullets "-"`; | ||
execSync(command, { stdio: 'inherit' }); | ||
|
||
}); | ||
|
||
console.log('Table of contents updated successfully.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding error handling for command execution.
The script effectively updates the table of contents for markdown files using markdown-toc
. However, using execSync
without error handling might lead to unhandled exceptions if the command fails. Consider wrapping the command execution in a try-catch block to handle potential errors gracefully.
try {
execSync(command, { stdio: 'inherit' });
} catch (error) {
console.error(`Error updating TOC for ${file}:`, error);
}
@@ -0,0 +1,69 @@ | |||
# Pull Request Guidelines | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary punctuation.
The punctuation mark after "Pull Request Guidelines" is unnecessary.
-# Pull Request Guidelines :+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
+# Pull Request Guidelines
Committable suggestion was skipped due to low confidence.
Tools
LanguageTool
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
The process in easy: | ||
1. Install `talawa-docs` on your system | ||
1. Launch docusaurus on your system according to the `talawa-docs`documentation. | ||
- A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammatical error.
The modal verb 'should' requires the verb's base form. Correct the sentence to: "A local version of docs.talawa.io
should automatically launch in your browser..."
- - A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/
+ - A local version of `docs.talawa.io` should automatically launch in your browser at http://localhost:3000/
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ | |
- A local version of `docs.talawa.io` should automatically launch in your browser at http://localhost:3000/ |
Tools
LanguageTool
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
Markdownlint
25-25: null
Bare URL used(MD034, no-bare-urls)
@@ -0,0 +1,52 @@ | |||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Redundant 'use strict' Directive
The 'use strict' directive is unnecessary in ES6 modules as they are in strict mode by default.
- 'use strict';
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
'use strict'; |
Tools
Biome
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
"lastName_invalid": "अंतिम नाम में केवल छोटे और बड़े अक्षर होने चाहिए", | ||
"password_invalid": "पासवर्ड में कम से कम एक लोअरकेस अक्षर, एक अपरकेस अक्षर, एक संख्यात्मक मान और एक विशेष अक्षर होना चाहिए", | ||
"email_invalid": "ईमेल में कम से कम 8 अक्षर होने चाहिए", | ||
"Password_and_Confirm_password_mismatches.": "पासवर्ड और पासवर्ड बेमेल होने की पुष्टि करें।", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate translation for password mismatch.
The keys "Password_and_Confirm_password_mismatches." and "passwordMismatches" have identical translations. Consider removing one to avoid redundancy.
- "Password_and_Confirm_password_mismatches.": "पासवर्ड और पासवर्ड बेमेल होने की पुष्टि करें।",
Also applies to: 17-17
if (!fs.existsSync('.env')) { | ||
fs.openSync('.env', 'w'); | ||
const config = dotenv.parse(fs.readFileSync('.env.example')); | ||
for (const key in config) { | ||
fs.appendFileSync('.env', `${key}=${config[key]}\n`); | ||
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding error handling for file operations.
While the logic for creating and populating the .env
file is correct, it would be beneficial to handle potential errors during file operations to ensure robustness.
try {
if (!fs.existsSync('.env')) {
fs.openSync('.env', 'w');
const config = dotenv.parse(fs.readFileSync('.env.example'));
for (const key in config) {
fs.appendFileSync('.env', `${key}=${config[key]}\n`);
}
} else {
checkEnvFile();
}
} catch (error) {
console.error('Error setting up .env file:', error);
}
if (process.env.PORT) { | ||
console.log( | ||
`\nCustom port for development server already exists with the value:\n${process.env.PORT}`, | ||
); | ||
shouldSetCustomPort = true; | ||
} else { | ||
const { shouldSetCustomPortResponse } = await inquirer.prompt({ | ||
type: 'confirm', | ||
name: 'shouldSetCustomPortResponse', | ||
message: 'Would you like to set up a custom port?', | ||
default: true, | ||
}); | ||
shouldSetCustomPort = shouldSetCustomPortResponse; | ||
} | ||
|
||
if (shouldSetCustomPort) { | ||
const customPort = await askForCustomPort(); | ||
|
||
const port = dotenv.parse(fs.readFileSync('.env')).PORT; | ||
|
||
fs.readFile('.env', 'utf8', (err, data) => { | ||
const result = data.replace(`PORT=${port}`, `PORT=${customPort}`); | ||
fs.writeFileSync('.env', result, 'utf8'); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom port setup logic is correct, but consider error handling.
The logic for setting a custom port is correct, but it would be beneficial to handle potential errors during file operations.
try {
if (shouldSetCustomPort) {
const customPort = await askForCustomPort();
const port = dotenv.parse(fs.readFileSync('.env')).PORT;
fs.readFile('.env', 'utf8', (err, data) => {
if (err) throw err;
const result = data.replace(`PORT=${port}`, `PORT=${customPort}`);
fs.writeFileSync('.env', result, 'utf8');
});
}
} catch (error) {
console.error('Error setting custom port:', error);
}
let shouldSetTalawaApiUrl: boolean; | ||
|
||
if (process.env.REACT_APP_TALAWA_URL) { | ||
console.log( | ||
`\nEndpoint for accessing talawa-api graphql service already exists with the value:\n${process.env.REACT_APP_TALAWA_URL}`, | ||
); | ||
shouldSetTalawaApiUrl = true; | ||
} else { | ||
const { shouldSetTalawaApiUrlResponse } = await inquirer.prompt({ | ||
type: 'confirm', | ||
name: 'shouldSetTalawaApiUrlResponse', | ||
message: 'Would you like to set up talawa-api endpoint?', | ||
default: true, | ||
}); | ||
shouldSetTalawaApiUrl = shouldSetTalawaApiUrlResponse; | ||
} | ||
|
||
if (shouldSetTalawaApiUrl) { | ||
let isConnected = false, | ||
endpoint = ''; | ||
|
||
while (!isConnected) { | ||
endpoint = await askForTalawaApiUrl(); | ||
const url = new URL(endpoint); | ||
isConnected = await checkConnection(url.origin); | ||
} | ||
|
||
const talawaApiUrl = dotenv.parse( | ||
fs.readFileSync('.env'), | ||
).REACT_APP_TALAWA_URL; | ||
|
||
fs.readFile('.env', 'utf8', (err, data) => { | ||
const result = data.replace( | ||
`REACT_APP_TALAWA_URL=${talawaApiUrl}`, | ||
`REACT_APP_TALAWA_URL=${endpoint}`, | ||
); | ||
fs.writeFileSync('.env', result, 'utf8'); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talawa API URL setup logic is correct, but consider error handling.
The logic for setting the Talawa API URL is correct, but it would be beneficial to handle potential errors during file operations.
try {
if (shouldSetTalawaApiUrl) {
let isConnected = false, endpoint = '';
while (!isConnected) {
endpoint = await askForTalawaApiUrl();
const url = new URL(endpoint);
isConnected = await checkConnection(url.origin);
}
const talawaApiUrl = dotenv.parse(fs.readFileSync('.env')).REACT_APP_TALAWA_URL;
fs.readFile('.env', 'utf8', (err, data) => {
if (err) throw err;
const result = data.replace(`REACT_APP_TALAWA_URL=${talawaApiUrl}`, `REACT_APP_TALAWA_URL=${endpoint}`);
fs.writeFileSync('.env', result, 'utf8');
});
}
} catch (error) {
console.error('Error setting Talawa API URL:', error);
}
if (shouldUseRecaptcha) { | ||
const useRecaptcha = dotenv.parse( | ||
fs.readFileSync('.env'), | ||
).REACT_APP_USE_RECAPTCHA; | ||
|
||
fs.readFile('.env', 'utf8', (err, data) => { | ||
const result = data.replace( | ||
`REACT_APP_USE_RECAPTCHA=${useRecaptcha}`, | ||
`REACT_APP_USE_RECAPTCHA=yes`, | ||
); | ||
fs.writeFileSync('.env', result, 'utf8'); | ||
}); | ||
let shouldSetRecaptchaSiteKey: boolean; | ||
if (process.env.REACT_APP_RECAPTCHA_SITE_KEY) { | ||
console.log( | ||
`\nreCAPTCHA site key already exists with the value ${process.env.REACT_APP_RECAPTCHA_SITE_KEY}`, | ||
); | ||
shouldSetRecaptchaSiteKey = true; | ||
} else { | ||
const { shouldSetRecaptchaSiteKeyResponse } = await inquirer.prompt({ | ||
type: 'confirm', | ||
name: 'shouldSetRecaptchaSiteKeyResponse', | ||
message: 'Would you like to set up a reCAPTCHA site key?', | ||
default: true, | ||
}); | ||
shouldSetRecaptchaSiteKey = shouldSetRecaptchaSiteKeyResponse; | ||
} | ||
|
||
if (shouldSetRecaptchaSiteKey) { | ||
const { recaptchaSiteKeyInput } = await inquirer.prompt([ | ||
{ | ||
type: 'input', | ||
name: 'recaptchaSiteKeyInput', | ||
message: 'Enter your reCAPTCHA site key:', | ||
validate: async (input: string): Promise<boolean | string> => { | ||
if (validateRecaptcha(input)) { | ||
return true; | ||
} | ||
return 'Invalid reCAPTCHA site key. Please try again.'; | ||
}, | ||
}, | ||
]); | ||
|
||
const recaptchaSiteKey = dotenv.parse( | ||
fs.readFileSync('.env'), | ||
).REACT_APP_RECAPTCHA_SITE_KEY; | ||
|
||
fs.readFile('.env', 'utf8', (err, data) => { | ||
const result = data.replace( | ||
`REACT_APP_RECAPTCHA_SITE_KEY=${recaptchaSiteKey}`, | ||
`REACT_APP_RECAPTCHA_SITE_KEY=${recaptchaSiteKeyInput}`, | ||
); | ||
fs.writeFileSync('.env', result, 'utf8'); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReCAPTCHA setup logic is correct, but consider error handling.
The logic for setting up ReCAPTCHA is correct, but it would be beneficial to handle potential errors during file operations.
try {
if (shouldUseRecaptcha) {
const useRecaptcha = dotenv.parse(fs.readFileSync('.env')).REACT_APP_USE_RECAPTCHA;
fs.readFile('.env', 'utf8', (err, data) => {
if (err) throw err;
const result = data.replace(`REACT_APP_USE_RECAPTCHA=${useRecaptcha}`, `REACT_APP_USE_RECAPTCHA=yes`);
fs.writeFileSync('.env', result, 'utf8');
});
let shouldSetRecaptchaSiteKey: boolean;
if (process.env.REACT_APP_RECAPTCHA_SITE_KEY) {
console.log(`\nreCAPTCHA site key already exists with the value ${process.env.REACT_APP_RECAPTCHA_SITE_KEY}`);
shouldSetRecaptchaSiteKey = true;
} else {
const { shouldSetRecaptchaSiteKeyResponse } = await inquirer.prompt({
type: 'confirm',
name: 'shouldSetRecaptchaSiteKeyResponse',
message: 'Would you like to set up a reCAPTCHA site key?',
default: true,
});
shouldSetRecaptchaSiteKey = shouldSetRecaptchaSiteKeyResponse;
}
if (shouldSetRecaptchaSiteKey) {
const { recaptchaSiteKeyInput } = await inquirer.prompt([
{
type: 'input',
name: 'recaptchaSiteKeyInput',
message: 'Enter your reCAPTCHA site key:',
validate: async (input: string): Promise<boolean | string> => {
if (validateRecaptcha(input)) {
return true;
}
return 'Invalid reCAPTCHA site key. Please try again.';
},
},
]);
const recaptchaSiteKey = dotenv.parse(fs.readFileSync('.env')).REACT_APP_RECAPTCHA_SITE_KEY;
fs.readFile('.env', 'utf8', (err, data) => {
if (err) throw err;
const result = data.replace(`REACT_APP_RECAPTCHA_SITE_KEY=${recaptchaSiteKey}`, `REACT_APP_RECAPTCHA_SITE_KEY=${recaptchaSiteKeyInput}`);
fs.writeFileSync('.env', result, 'utf8');
});
}
}
} catch (error) {
console.error('Error setting up ReCAPTCHA:', error);
}
if (shouldLogErrors) { | ||
const logErrors = dotenv.parse(fs.readFileSync('.env')).ALLOW_LOGS; | ||
|
||
fs.readFile('.env', 'utf8', (err, data) => { | ||
const result = data.replace(`ALLOW_LOGS=${logErrors}`, 'ALLOW_LOGS=YES'); | ||
fs.writeFileSync('.env', result, 'utf8'); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging setup logic is correct, but consider error handling.
The logic for enabling logging is correct, but it would be beneficial to handle potential errors during file operations.
try {
if (shouldLogErrors) {
const logErrors = dotenv.parse(fs.readFileSync('.env')).ALLOW_LOGS;
fs.readFile('.env', 'utf8', (err, data) => {
if (err) throw err;
const result = data.replace(`ALLOW_LOGS=${logErrors}`, 'ALLOW_LOGS=YES');
fs.writeFileSync('.env', result, 'utf8');
});
}
} catch (error) {
console.error('Error enabling logging:', error);
}
This PR has too many submitted files. Please ensure the following: Make your PR modifications based on the current Closing |
What kind of change does this PR introduce?
Upgrade of dependencies
Issue Number:
Fixes #1942
Did you add tests for your changes?
Yes. Existing tests have been validated to ensure compatibility.
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
This pull request addresses the issue of upgrading @types/jest as described in issue #1942. The previous attempt to upgrade these dependencies via the dependabot job resulted in failing tests, which indicated that additional updates were required for compatibility. This major revision upgrade involves updating to the latest versions of jest and @types/jest. The goal is to ensure that the new versions integrate seamlessly without affecting existing functionality, and that all tests pass successfully.
Does this PR introduce a breaking change?
No, this PR does not introduce any breaking changes. All existing configurations have been preserved, and no additional functionality has been modified.
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Documentation
README.md
and added detailed installation and contribution guidelines.Style
Chores