Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

有3个C API导出名称风格规范不一致 #114

Open
sdcb opened this issue Jan 30, 2023 · 1 comment
Open

有3个C API导出名称风格规范不一致 #114

sdcb opened this issue Jan 30, 2023 · 1 comment

Comments

@sdcb
Copy link
Contributor

sdcb commented Jan 30, 2023

注意到有3个C API导出名称不一致:
分别是:

  • get_cpu_num
  • get_thread_num
  • set_thread_num

image

应该使用整体的规范,比如:

  • fcvGetCpuNum
  • fcvGetThreadNum
  • fcvSetThreadNum

建议更具体一些的名字,比如:

  • fcvGetPhysicalThreadCount
  • fcvGetLogicalThreadCount
  • fcvSetThreadPoolThreadCount
@sdcb sdcb changed the title C API导出名称一致性 有3个C API导出名称风格规范不一致 Jan 30, 2023
@TomasRan
Copy link
Collaborator

嗯,这个计划是下个版本加进来,因为当前版本已经提测了不好修改。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants