Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promisify #3

Open
ghost opened this issue Oct 1, 2016 · 1 comment
Open

promisify #3

ghost opened this issue Oct 1, 2016 · 1 comment
Assignees
@lmammino

Comments

@ghost
Copy link

ghost commented Oct 1, 2016

The promisify function (Chapter04/01_promisify.js) contains a reference to the arguments variable in the callback which happens to be an arrow function (with lexical arguments).

Please find attached a test which demonstrates the problem.

Thank you.

test.js.txt
@mmurygin
Copy link

mmurygin commented Jan 10, 2018 •
edited
Loading

+1 promisify function in Chapter04 contains an error. The implementation from @k365 is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmammino lmammino

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmammino @mmurygin