feat: 增加获取仪表盘集群数据汇总的接口 getSummaryClusterInfo #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zh-vah
changed the title
ddadaal
requested changes
Oct 30, 2025
protos/config.proto
Outdated
Comment on lines
109
to
110
| NOT_AVAILABLE = 0; | ||
| AVAILABLE = 1; |
Member
There was a problem hiding this comment.
根据protobuf的设计规范，enum的0值应不包含业务含义。所以这里把0（空值）的值的含义设置为UNKNOWN，NOT_AVAILABLE和AVAILABLE分别为1和2。
另外，这里为什么是一个enum？后续partition还可能会有其他状态？
Author
There was a problem hiding this comment.
问了下薛老师和秦老师，说是可能还会有其它状态。现在只展示两种状态NOT_AVAILABLE和AVAILABLE。
ddadaal
requested changes
Oct 31, 2025
ddadaal
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加的接口字段同ai一致