fix calculation of PSNR(if only_in_mask) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Maemaemaeko wants to merge 1 commit into PJLab-ADG:main from Maemaemaeko:main

Maemaemaeko commented Feb 26, 2025

If only_in_mask is True, the PSNR is too small, because the shape of mask does not match x (or y).

For example, when x(or y) is (W, H, 3) and mask is (W, H, 1), the sum of error should be divided by not mask.sum(), but mask.sum()*3.


          fix calculation of PSNR(if only_in_mask)

8e8b98c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet