Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalized outputed functions for convolution with PDAW #7

Open
JanosJiri opened this issue Aug 30, 2024 · 2 comments
Open

Normalized outputed functions for convolution with PDAW #7

JanosJiri opened this issue Aug 30, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
v1.0.1

Comments

@JanosJiri
Copy link
Collaborator

Currently, the code outputs the pulse intensity. However, convolution should be done with normalized pulse intensity. The normalization should be a simple analytic integral that can be evaluated for all envelopes.
@danielhollas
Copy link
Collaborator

Is this a bug? Or just an inconsistency in the output?

@JanosJiri
Copy link
Collaborator Author

It is not a bug, just to make it a bit more user-friendly.

@danielhollas danielhollas added the enhancement New feature or request label Aug 30, 2024
@danielhollas danielhollas added this to the v2.0.0 milestone Sep 24, 2024
@JanosJiri JanosJiri modified the milestones: v2.0.0, v1.0.1 Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.1
Development

No branches or pull requests
2 participants
@danielhollas @JanosJiri