Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed tests for atom definitions #90

Open
hartytp opened this issue Jan 7, 2025 · 0 comments
Open

More detailed tests for atom definitions #90

hartytp opened this issue Jan 7, 2025 · 0 comments

Comments

@hartytp
Copy link
Contributor

hartytp commented Jan 7, 2025

Writing the tests, I was surprised how many small typos I found in the atomic structure data. Just silly things like an exponent missing in a transition frequency. It feels like there is still some data in this package which no one has ever used for a calculation. We should probably aim for every property of every atom to be tested in some way (e.g. transition frequencies can be compared by checking saturation intensity calculations). These don't all need to be ultra-precise - even just ruling out gross mistakes is quite useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant