txHelper error handling additions (#4199)

* adds a bit more error handling for non-catastrphic error states in transaction handling

* fixes null ref

* adds isValidHash()

Author: mikeshultz

packages/graphql/src/mutations/_txHelper.js

@@ -41,6 +41,15 @@ export async function checkMetaMask(from) {
 // to hang
 const isServer = typeof window === 'undefined'
 
+/**
+ * Check if the hash is a valid transaction hash
+ * @param hash {string} - A suspected transaction hash
+ * @returns {boolean} - if hash was a valid transaction hash
+ */
+function isValidHash(hash) {
+  return typeof hash === 'string' && [66, 64].includes(hash.length)
+}
+
 // Should we try to use the relayer
 function useRelayer({ mutation, value }) {
   if (isServer) return
@@ -311,6 +320,11 @@ async function handleCallbacks({ callbacks, val }) {
 async function handleHash({ hash, from, mutation }) {
   debug(`got hash ${hash}`)
 
+  if (!isValidHash(hash)) {
+    console.error(`Received hash: ${hash}`)
+    throw new Error('handleHash got invalid tx hash!')
+  }
+
   contracts.transactions[from] = contracts.transactions[from] || []
   contracts.transactions[from].unshift({
     id: hash,
@@ -441,7 +455,7 @@ async function sendViaRelayer({
     throw new Error('No transaction hash from relayer!')
   }
   const txHash = resp.id
-  if (typeof txHash !== 'string' || ![66, 64].includes(txHash.length)) {
+  if (!isValidHash(txHash)) {
     throw new Error('Invalid transaction hash returned by relayer!')
   }
 
@@ -465,7 +479,12 @@ async function sendViaRelayer({
     let receipt
     const responseBlocks = async ({ newBlock }) => {
       if (!receipt) {
-        receipt = await web3.eth.getTransactionReceipt(txHash)
+        try {
+          receipt = await web3.eth.getTransactionReceipt(txHash)
+        } catch (err) {
+          console.error(err)
+          return
+        }
       }
       /**
        * There some potential races going on here, where we can't use === for
@@ -563,10 +582,7 @@ async function sendViaWeb3({
     } else if (txHash === null) {
       console.error(tx)
       throw new Error('Transaction hash returned null.  Invalid tx?')
-    } else if (
-      typeof txHash !== 'string' ||
-      ![66, 64].includes(txHash.length)
-    ) {
+    } else if (!isValidHash(txHash)) {
       console.error('Invaild hash: ', txHash)
       throw new Error('Invalid transaction hash returned by web3!')
     }
@@ -582,10 +598,20 @@ async function sendViaWeb3({
       })
     })
     .on('error', function(error) {
+      /**
+       * This seems like an internal web3.js error and not caused by our code.
+       * it should be temporary, so we're just gonna ignore it.
+       */
+      if (error && error.message && error.message.includes('Invalid params')) {
+        console.error(error.message)
+        return
+      }
+
       if (txHash) {
+        const hashTosend = isValidHash(txHash) ? txHash : null
         pubsub.publish('TRANSACTION_UPDATED', {
           transactionUpdated: {
-            id: txHash,
+            id: hashTosend,
             status: 'error',
             error,
             mutation