Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: useLoadData callback functions #36

Merged
merged 5 commits into from
May 15, 2024
Merged

Feat: useLoadData callback functions #36

merged 5 commits into from
May 15, 2024

Conversation

NielsJPeschel
Copy link
Contributor

Proposed changes

Create error, success, and complete callback functions designed to be passed into the callback for useLoadData
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@NielsJPeschel NielsJPeschel requested a review from nthurow May 14, 2024 21:30
@nthurow nthurow merged commit 1288cb5 into main May 15, 2024
5 checks passed
@nthurow nthurow deleted the callback-functions branch May 15, 2024 18:50
@nthurow
Copy link
Contributor

nthurow commented May 15, 2024

Do we have any docs for these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants