Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise error handling in the UI #15

Open
jvolker opened this issue Feb 16, 2020 · 0 comments
Open

Normalise error handling in the UI #15

jvolker opened this issue Feb 16, 2020 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@jvolker
Copy link
Collaborator

jvolker commented Feb 16, 2020

Following up from #12

@jmwohl:

The notifications package I was using hasn't been maintained and doesn't work, so either needs to be forked and fixed or swapped out for another package

This is for the success/info/error notifications for the UI (not the error warnings in edit forms).

I decided to just pull the redux-notifications code into our project rather than use the unmaintained dependency. I've updated the code a bit so we should have working notifications again now.

Not sure if this is new or what redux-notifications was using anyway under the hood, but what about Bootstrap Alerts? https://getbootstrap.com/docs/4.0/components/alerts/

@jvolker jvolker added the dependencies Pull requests that update a dependency file label Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant