You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🧐 Motivation
Currently, the BaseCustomCurve uses it's own encoding for modifyParams in _modifyLiquidity. However, ideally it uses the same struct as in BaseCustomAccounting so that there's mode code overlap and allows the possibility of adding more explicit checks in the add/removeLiquidity functions (such as checking that poolManager.modifyLiquidity matches the function type -- i.e. positive for add liquidity, negative for remove liquidity)
📝 Details
N/A
The text was updated successfully, but these errors were encountered:
🧐 Motivation
Currently, the
BaseCustomCurve
uses it's own encoding formodifyParams
in_modifyLiquidity
. However, ideally it uses the same struct as inBaseCustomAccounting
so that there's mode code overlap and allows the possibility of adding more explicit checks in theadd/removeLiquidity
functions (such as checking thatpoolManager.modifyLiquidity
matches the function type -- i.e. positive for add liquidity, negative for remove liquidity)📝 Details
N/A
The text was updated successfully, but these errors were encountered: