Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _modifyLiquidity in BaseCustomCurve to use IPoolManager.ModifyLiquidityParams #44

Open
cairoeth opened this issue Feb 20, 2025 · 0 comments

Comments

@cairoeth
Copy link
Collaborator

🧐 Motivation
Currently, the BaseCustomCurve uses it's own encoding for modifyParams in _modifyLiquidity. However, ideally it uses the same struct as in BaseCustomAccounting so that there's mode code overlap and allows the possibility of adding more explicit checks in the add/removeLiquidity functions (such as checking that poolManager.modifyLiquidity matches the function type -- i.e. positive for add liquidity, negative for remove liquidity)

📝 Details
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant