Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using transient storage in Governor and AccessManager #4993

Open
ernestognw opened this issue Apr 4, 2024 · 1 comment · May be fixed by #5078
Open

Consider using transient storage in Governor and AccessManager #4993

ernestognw opened this issue Apr 4, 2024 · 1 comment · May be fixed by #5078
Milestone
[Archived] 5.1

Comments

@ernestognw
Copy link
Member

📝 Details

Similar to #4888, but regarding the following variables:

The Governor call is a Bytes32Deque, which makes me wonder if we may add a transient version of some libraries.
Both are technically breaking changes, but I don't see how they would affect the contract given the values are private.
@Amxx
Copy link
Collaborator

Amxx commented Apr 5, 2024

For structs like Bytes32Deque, I would wait for solidity to support the transient keyword, and then I would duplicate all function that currently have a storage pointer in their argument to also have a transient version of the function.

Like this

@ernestognw ernestognw modified the milestones: 5.x, 5.1 Apr 10, 2024
@Amxx Amxx linked a pull request Jun 12, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
[Archived] 5.1
Development

Successfully merging a pull request may close this issue.

Store AccessManager's executionId in transient storage OpenZeppelin/openzeppelin-contracts
2 participants
@Amxx @ernestognw