Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document use of delegateBySig #2927

Open
frangio opened this issue Oct 28, 2021 · 3 comments · May be fixed by #3015
Open

Document use of delegateBySig #2927

frangio opened this issue Oct 28, 2021 · 3 comments · May be fixed by #3015

Comments

@frangio
Copy link
Contributor

frangio commented Oct 28, 2021

We don't seem to have documentation for the format of the message that needs to be signed.
@hack3r-0m
Copy link

@frangio is it for ERC20Votes ? (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/ERC20Votes.sol#L144 )
I can add documentation for it, compound published good article on it https://medium.com/compound-finance/delegation-and-voting-with-eip-712-signatures-a636c9dfec5e

@frangio
Copy link
Contributor Author

frangio commented Dec 8, 2021

Yes, for ERC20Votes. We need to document here:

openzeppelin-contracts/contracts/token/ERC20/extensions/ERC20Votes.sol

Lines 141 to 143 in 8ef7655

/**
* @dev Delegates votes from signer to `delegatee`
*/

the format of the signature, i.e. that it's an EIP712 signature with certain fields and values. We can also add a link to the article you shared!

A PR would be appreciated.

hack3r-0m added a commit to hack3r-0m/openzeppelin-contracts that referenced this issue Dec 11, 2021
@hack3r-0m
Add documentation for delegateBySig (OpenZeppelin#2927)
6fec458
@hack3r-0m hack3r-0m linked a pull request Dec 11, 2021 that will close this issue
Open
3 tasks
@crazyrabbitLTC
Copy link
Contributor

Any update on this? I think I don't see it in the tests for Governance either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add documentation for delegateBySig (#2927) hack3r-0m/openzeppelin-contracts
3 participants
@frangio @crazyrabbitLTC @hack3r-0m