Merge pull request #173 from OpenVoxProject/dependabot/bundler/rubocop-tw-1.80.0

Update rubocop requirement from ~> 1.79.0 to ~> 1.80.0

Author: bastelfreak

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.79.0.
+# using RuboCop version 1.80.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -11,7 +11,6 @@ I18n/GetText/DecorateFunctionMessage:
   Enabled: false
 
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect.
 I18n/GetText/DecorateString:
   Enabled: false
 
@@ -130,19 +129,13 @@ Lint/ToJSON:
     - 'lib/puppet/pops/serialization/json.rb'
 
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
 # NotImplementedExceptions: NotImplementedError
 Lint/UnusedMethodArgument:
   Enabled: false
 
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect.
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/puppet/application/face_base.rb'
-
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, CheckForMethodsWithNoSideEffects.
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
   Exclude:
     - 'lib/puppet/type/schedule.rb'
@@ -324,7 +317,7 @@ Style/DoubleNegation:
     - 'lib/puppet/util/feature.rb'
 
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, EnforcedStyle, AllowComments.
+# Configuration parameters: EnforcedStyle, AllowComments.
 # SupportedStyles: empty, nil, both
 Style/EmptyElse:
   Enabled: false
@@ -341,7 +334,7 @@ Style/EmptyLiteral:
     - 'lib/puppet/type.rb'
 
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: compact, expanded
 Style/EmptyMethod:
   Enabled: false
@@ -496,7 +489,6 @@ Style/MultilineMemoization:
   Exclude:
     - 'lib/puppet/application.rb'
     - 'lib/puppet/pops/types/types.rb'
-    - 'lib/puppet/type.rb'
 
 # This cop supports safe autocorrection (--autocorrect).
 Style/MultilineTernaryOperator:
@@ -574,6 +566,11 @@ Style/RedundantParentheses:
     - 'lib/puppet/type/tidy.rb'
     - 'lib/puppet/util/windows/com.rb'
 
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/RedundantSort:
+  Exclude:
+    - 'lib/puppet/provider/package/nim.rb'
+
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit

Gemfile

@@ -53,7 +53,7 @@ group(:test) do
   gem 'webrick', '~> 1.7', require: false
   gem 'yard', require: false
 
-  gem 'rubocop', '~> 1.79.0', require: false, platforms: [:ruby]
+  gem 'rubocop', '~> 1.80.0', require: false, platforms: [:ruby]
   gem 'rubocop-i18n', '~> 3.0', require: false, platforms: [:ruby]
   gem 'rubocop-performance', '~> 1.0', require: false, platforms: [:ruby]
   gem 'rubocop-rake', '~> 0.6', require: false, platforms: [:ruby]

lib/puppet/file_system.rb

@@ -288,7 +288,7 @@ def self.readlink(path)
   # @api public
   #
   def self.unlink(*paths)
-    @impl.unlink(*(paths.map { |p| assert_path(p) }))
+    @impl.unlink(*paths.map { |p| assert_path(p) })
   end
 
   # @return [File::Stat] object for the named file.

lib/puppet/indirector/catalog/compiler.rb

@@ -169,7 +169,7 @@ def inlineable?(resource, sources)
     elsif sources.empty?
       # TRANSLATORS Inlining refers to adding additional metadata (in this case we are not inlining)
       Puppet::Util::Profiler.profile(_("Not inlining resource without sources"), [:compiler, :static_compile_inlining, :skipped_file_metadata, :no_sources]) { false }
-    elsif !(sources.all? { |source| source =~ /^puppet:/ })
+    elsif !sources.all? { |source| source =~ /^puppet:/ }
       # TRANSLATORS Inlining refers to adding additional metadata (in this case we are not inlining)
       Puppet::Util::Profiler.profile(_("Not inlining unsupported source scheme"), [:compiler, :static_compile_inlining, :skipped_file_metadata, :unsupported_scheme]) { false }
     else

lib/puppet/indirector/file_bucket_file/file.rb

@@ -234,7 +234,7 @@ def path_for(bucket_path, digest, subfile = nil)
     # @api private
     def verify_identical_file(contents_file, bucket_file)
       (bucket_file.to_binary.bytesize == Puppet::FileSystem.size(contents_file)) &&
-        (bucket_file.stream() { |s| Puppet::FileSystem.compare_stream(contents_file, s) })
+        bucket_file.stream() { |s| Puppet::FileSystem.compare_stream(contents_file, s) }
     end
 
     # @param contents_file [Pathname] Opaque file path to intended backup

lib/puppet/pops/validation/checker4_0.rb

@@ -43,7 +43,7 @@ def initialize(diagnostics_producer)
     @acceptor = diagnostics_producer
 
     # Use null migration checker unless given in context
-    @migration_checker = (Puppet.lookup(:migration_checker) { Migration::MigrationChecker.new() })
+    @migration_checker = Puppet.lookup(:migration_checker) { Migration::MigrationChecker.new() }
   end
 
   # Validates the entire model by visiting each model element and calling `check`.

lib/puppet/provider/package/nim.rb

@@ -274,7 +274,7 @@ def determine_latest_version(showres_output, package_name)
       [packages[package_name][version], nil]
     else
       versions = packages[package_name].keys
-      latest_version = (versions.sort { |a, b| Puppet::Util::Package.versioncmp(b, a) })[0]
+      latest_version = versions.sort { |a, b| Puppet::Util::Package.versioncmp(b, a) }[0]
       [packages[package_name][latest_version], latest_version]
     end
   end

lib/puppet/type.rb

@@ -374,11 +374,9 @@ def copy_metaparams(parameters)
   # @see uniqueness_key
   # @return [Array<Puppet::Parameter>] WARNING: this return type is uncertain
   def self.key_attribute_parameters
-    @key_attribute_parameters ||= (
-      @parameters.find_all { |param|
-        param.isnamevar? or param.name == :name
-      }
-    )
+    @key_attribute_parameters ||= @parameters.find_all { |param|
+      param.isnamevar? or param.name == :name
+    }
   end
 
   # Returns cached {key_attribute_parameters} names.